Surface Claude account identity in quota skip notices

[d-morrison]

When a review is skipped due to rate limit/quota or credential exhaustion, include the Claude account identity (e.g. from vars.CLAUDE_CODE_ACCOUNT_EMAIL) in the skip notice so users know which account quota exhausted.

[github-actions]

PR Preview Action v1.8.1
Preview removed because the pull request was closed.

_{2026-10-08 00:24 UTC}

[github-actions]

Claude finished review — View run

---

No collisions. The fix round is complete, verified empirically, and all three prior findings are properly addressed with no new issues introduced.

Review: PR #1018 — Surface Claude account identity in quota skip notices

What changed since the last review round (commit 5b8cd7b8 → d83a0be2)

One commit, three files, directly addressing all three findings from the prior round:

1. .github/workflows/scripts/build-quota-skip-notice.sh (finding 1, required): The unreachable nested fallback ${CLAUDE_ACCOUNT:-${CLAUDE_CODE_ACCOUNT_EMAIL:-${ACCOUNT_EMAIL:-}}} was replaced with the simple ${CLAUDE_ACCOUNT:-}, exactly as suggested — matching how QUOTA_REASON/QUOTA_MESSAGE/RUN_URL are each read via a single name. The workflow-level || fallback chain in claude-code-review.yml (vars.CLAUDE_CODE_ACCOUNT_EMAIL || vars.CLAUDE_ACCOUNT_EMAIL || vars.CLAUDE_ACCOUNT || '') remains the single point of resolution, and that's a GitHub Actions expression evaluated at the workflow-call site — legitimate, not duplicated shell logic.

2. changelog.d/report-claude-account-in-quota-skip.added.md (finding 2, suggestion): Added, correctly named (<slug>.<category>.md, no dots in slug, valid category per changelog.d/README.md), with semantic line breaks and no collision with existing fragment filenames.

3. website/reference/claude-code-review.qmd's new "## Variables" section (finding 3, suggestion): Documents CLAUDE_CODE_ACCOUNT_EMAIL with its fallback chain and precedence, plus backfills a missing row for the pre-existing CLAUDE_AGENT_DISABLED variable (confirmed pre-existing via grep across README.md, website/workflows.qmd, and examples/claude-code-review.yml — not a hallucination). Table syntax is valid Markdown.

Verification performed

• Reconstructed the exact pre-fix and post-fix build-quota-skip-notice.sh plus its test file from the diff and ran run-build-quota-skip-notice-tests.sh directly: all 49 assertions pass, including the account-rendering and multiline-collapse cases.
• Confirmed via git diff 5b8cd7b8 d83a0be2 -- .github/workflows/scripts/build-quota-skip-notice.sh that the only script change is exactly the one-line fallback simplification requested — no other logic shifted.
• Confirmed the claude-account input is not a workflow_call input (it's an internal composite-action input fed from vars.*), so the CLAUDE.md "new workflow_call input needs 3-site doc sync" rule (README.md key-inputs table, website/workflows.qmd, reference page) doesn't apply here — only the reference-page doc addition was appropriate, and that's what was added.
• Non-blocking finding 4 from the prior round (no backtick-escaping for the account string) was correctly left unaddressed; the author/prior consensus treated it as non-blocking since vars.* is only settable by trusted repo-admin/write-access actors, not attacker-controlled input.

No new issues found in this round's diff.

Verdict

Ready for merge — the prior round's required finding (unreachable/untested fallback chain) is fixed exactly as prescribed and empirically verified (49/49 tests pass), and both non-blocking documentation suggestions (changelog fragment, vars.* convention docs) were also addressed. See the prior round's full review at #1018 (comment) (summary posted 2026-10-08T00:17:27Z, "Needs more work") — that verdict no longer stands; this diff resolves it.

Structured Review Data (JSON)

{
  "schema_version": "1.1",
  "reviewer": "claude",
  "commit_sha": "d83a0be2580bc0843f47d6bab705370df893f849",
  "verdict": "CLEAN",
  "findings": [],
  "detailed_assessment": "build-quota-skip-notice.sh's fallback chain was simplified to a single CLAUDE_ACCOUNT read, verified via reconstructed offline test run (49/49 assertions pass) and a direct diff confirming no other logic changed.",
  "holistic_assessment": "All three prior-round requirements (dead fallback removal, changelog fragment, vars.* documentation) are satisfied with no scope creep, no regression to the vars resolution mechanics, and no new doc-sync gaps introduced."
}

Reviewed commit: d83a0be

Reviewed commit: d83a0be

[github-actions]

💰 Cost: $1.8394 (review) — run