Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
|
Maybe we relocate the 'Code Preview' and the 'Suggested Deselected Patches' sections to the TopBar in the Patch Selection Screen? It's kinda looks ugly and cramped right now I feel. Will try to figure something out for this soon. |
|
If code preview you mean the CLI command, then yes it can be at the top of the screen. It can be show if "expert mode" is enabled. The simplified mode setting can be inverted to "expert mode" and it's default off, to match Android Manager app. Suggested deselected patches can be removed entirely. Patches already declare if they are default included, and we don't want hard coded patch preferences or anything else. Ideally the only hard coded thing we should use, is a package name to app name lookup, so a human readable app name is shown and not the ugly package name. Eventually this will change so it's not needed, but for now it's ok. |
|
The simple mode progress UI stub can be removed too since it's not easy to use with CLI text usage. |
Got it. I'll remove the suggested patches thingy entirely. Will integrate it into the patch card iteslf just like how mobile manager does it. |
Do I do what the normal mode does and show the progress bar just spinning but no actual number? |
|
Was looking at adding this #26 . Saw your comment https://github.com/MorpheApp/morphe-patches/issues/336 on keeping them separate for the manager and the CLI. So, we add a flag that keeps only our needed lib and deletes other libs right? Or we could make this a GUI only option too and the Expert Mode gets the option to do this now since we are able to track the user device's architecture if they are connected over ADB (or give them an option to choose). |
|
Rip-libs can be a cli argument. Can be something like
I think this should be do-able by deleting subdirectories before apktool recompiles the app. Or remove before zipping the files into the final apk, or possibly even remove from the apk after it's created. Deleting before APKTool would be preferred if possible, but whatever is simplest may be the best. |
|
If a patch is not recommended the patches.mpp file sets "use" to false right? For youtube, only 2 out of the 61 patches have this field set to false,so naturally the gui auto selects the rest 59 and unselects those 2 and then lets the user decide what they want to do. However on the mobile patcher seems to deselect many more patches and shows only 54/61 selected. How is it doing that? |
|
The Android Manager still auto selects all patches with But it will remember the last selected patches if using expert mode. Maybe you already patched using expert mode and excluded some patches? |
Ah, that's probably it. |
Added --riplibs like you said here. Right as it re-aligns the apk and before the signing it, it rips the libs that the user doesn't want. Right now it does it only for youtube. Will test and add reddit too since reddit says universal too. Size seems to be dropping by 50% for youtube. |
|
Please make a separate PR with riplibs. Can merge that now. |
9f434b7 to
089d21f
Compare
|
Add the CLI changes to the new PR, this PR has those changes and the GUI changes that riplibs needs. I am hoping I did it right here too? Those files won't cause nay conflicts in the future when this merges with dev branch right? |
|
Correct there shouldn't be problems after riplibs PR is merged. |
|
A patch file and a url can be distinguished by looking at the parameter.
|
ahh yea, that's much better |
|
Did we figure out if proguard can be used to reduce the download size? If not, we could merge this to dev very soon and do any other fixes/changes in additional PR's |
|
Yea, looked into Proguard and R8 usage. We could reduce some of the size but that would require removing some core parts from the compose desktop which is kinda risky and will need additional testing. |
|
If you try, add a proguard exclusion on all of compose and see if that is good enough. Patcher will also need an exclusion. See proguard config in Morphe Manager because it uses compose and proguard shrinks the apk. |
|
I looked through it and am having a bit of a hard time understanding how to implement it in this project. I'll probably have to pass the entire ProGuard section over to you. |
|
I'll try to see if it's simple. Ignore failing build, jitpack is having major outages. |
|
Sure thing, thanks a lot! |
|
Don't exclude 'aapt2' binaries built for Android architectures |
|
Reverted it. I had probably made the change at the wrong place too so this reverts all of that. |
|
I want to report that another person has started to work on a similar project. |
|
I stumbled across it the other day. Commented on their post too. Haven't received any message or feedback so far, but would love to see what they think. |
I see. Let's wait and see. I just told him about your project on Reddit btw. The artifact you sent me is worling flawlessly (apart from the patches with settings not being configurable for now). |
|
No new artifacts as of yet. Have been working on this: 1 and 2 on the cli side is pretty much done. I will get to finishing 3 soon. If it takes time, then maybe the gui will first get pushed into dev and this will be a update soon after launch. |
|
Artifacts are found under the checks tab of this PR, inside the build pull request action, and at the bottom is the build artifact: https://github.com/MorpheApp/morphe-cli/actions/runs/22946899212/artifacts/5867443878 |
He replied to me here he also shared his Telegram if you want to get in touch |
|
@ruizlenato Heya! This was the PR I was talking about. Take a look and see how you like it! |
|
ProGuard does not give any substantial improvements over shadow jar minimize, and it's kind of messy with the config because patcher uses both Java and Android dependencies and ProGuard needs a complex config to work right. After removing a few shadow jar minimize excludes that don't seem to be needed, the cli jar is now 130mb. Larger than 50mb without the GUI but still a reasonable size and CLI won't be updated often. |
0679766 to
703d465
Compare
|
I force pushed to cleanup the merge history. @prateek-who You'll need reset to origin if you want to make other changes. |
434232d to
106619f
Compare
|
@wchill @inotia00 Feel free to review. @prateek-who Please look over everything once more and make any other changes you'd like. If there are no new reviews then I will merge this 2 days from now. |
|
Will reset and do the remaining changes. Revamping the UI a bit, but maybe I'll release that as a future update. |
|
I need to be executed for the amount of times I have messed up doing a simple job on git. |
|
I think a re-write or major changes can be a separate PR so we have CLI release before and after the major changes. Keep your changes locally and after this PR is merged we can open a second PR work in progress with continued changes. I will reset to the commit before the overhaul. |
355f29c to
106619f
Compare
|
Sure thing. Thanks a lot! Sorry for the mess! |

The GUI update with most of the stuff. Some stuff might be broken, will keep fixing them as they appear. Also, please check the build.gradle.kts file once just to make sure I didn't mess up anything that the team might have added there.
Tired of using the old CLI? Not sure where to get what files to get the CLI running? Too busy to read the documentation? Worry not ladies and gentlemen, we present to you the Morphe GUI!
We got shiny new look coat of paint to suit your needs with more coming on the way!
Select the patch you want to use, including stable and dev patches!
See all the patches that will be applied even before they are applied! Are you a power user and want to make small tweak to the final command? With one click copy, your command will be all yours to experiment with! Also, see the morphe team's most deselected patches and decide if you want to listen to them :)
See the patch getting applied in real time just like how it does on the mobile patcher!
Directly install the app to your phone over ADB if you are plugged in to your computer and not worry about transferring the app and installting it again!
And in case you happen to be in a hurry want the entire process to be done ASAP, we got your back there too!
Visit your nearest morphe github to grab your CLI's GUI