Update to run container as non-root user and other security updates#4
Open
m4rc77 wants to merge 6 commits intoMorbZ:masterfrom
Open
Update to run container as non-root user and other security updates#4m4rc77 wants to merge 6 commits intoMorbZ:masterfrom
m4rc77 wants to merge 6 commits intoMorbZ:masterfrom
Conversation
… to nginx 1.17. Using https:// as default redirect target.
Updated readme; fixes usage of port 8080 with jwilder/nginx-proxy
wirespecter
reviewed
Apr 13, 2022
| EXPOSE 80 | ||
| EXPOSE 8080 | ||
|
|
||
| USER 1000 |
There was a problem hiding this comment.
I have a question. Even if you switched to a non-root user here, wouldn't nginx still be running as root in the background?
My point is: if an attacker finds a way to exploit nginx he will be root.
To avoid this: a new non-root user must be created and add user nonroot_username; in nginx conf so that nginx is not run as root too :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request contains the following changes:
https://as default redirect target instead ofhttp://.This change might brake existing clients. Maybe a new release/branch is advised.