Skip to content

fix(tui): recognize CSI-u Shift+Enter as newline #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
haosenwang1018 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(tui): recognize CSI-u Shift+Enter as newline #272

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/shift-enter-csi-u.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@moonshot-ai/kimi-code": patch
---

fix(tui): treat CSI-u Shift+Enter as an editor newline
1 change: 1 addition & 0 deletions apps/kimi-code/src/tui/components/editor/custom-editor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@ function stripSgr(s: string): string {

function getNewlineInput(data: string): string | undefined {
if (data === '\n' || data === '\u001B\r' || data === '\u001B[13;2~') return data;
if (data === '\u001B[13;2u') return '\n';
if (matchesKey(data, Key.ctrl('j'))) return '\n';
return undefined;
}
Expand Down
7 changes: 4 additions & 3 deletions apps/kimi-code/test/tui/components/editor/custom-editor.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,17 +208,18 @@ describe('CustomEditor paste marker expansion', () => {
});

describe('CustomEditor shortcut telemetry hooks', () => {
it('reports newline shortcuts, including Ctrl-J, before delegating to the base editor', () => {
it('reports newline shortcuts, including Ctrl-J and CSI-u Shift+Enter, before delegating to the base editor', () => {
const editor = makeEditor();
const onInsertNewline = vi.fn();
editor.onInsertNewline = onInsertNewline;

editor.handleInput('a');
editor.handleInput('\n');
editor.handleInput('\u001B[106;5u');
editor.handleInput('\u001B[13;2u');

expect(onInsertNewline).toHaveBeenCalledTimes(2);
expect(editor.getText()).toBe('a\n\n');
expect(onInsertNewline).toHaveBeenCalledTimes(3);
expect(editor.getText()).toBe('a\n\n\n');
});

it('reports undo shortcuts before delegating to the base editor', () => {
Expand Down