Add 'Use Broadcast' sync option to send UDP audio data#10
Open
netmindz wants to merge 1 commit into
Open
Conversation
…adcast instead of multicast
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for using subnet broadcast instead of multicast when sending audio sync packets, providing more flexibility for network configurations. It introduces a new
audioSyncBroadcastoption, updates the configuration and UI to support this, and ensures the new setting is properly saved and restored.This is useful as a work around for networks that do not support multicast properly and does also appear to help multiple devices actually receive the data at the same time in some cases (some WIFI networks turn multicast into unicast)
Network transmission improvements:
audioSyncBroadcastflag to allow sending audio sync packets to the subnet broadcast address instead of using multicast. The code now computes the broadcast address and sends packets accordingly when this option is enabled. (audio_reactive.h, [1] [2]Configuration and persistence:
broadcastoption, ensuring it is saved to and loaded from the configuration JSON. (audio_reactive.h, [1] [2]User interface enhancements:
audio_reactive.h, audio_reactive.hL3204-R3218)