fix: use system=true for all add_requires dependencies#349
Open
akarsh1010 wants to merge 1 commit into
Open
Conversation
Fixes issue MoganLab#342 - allows building lolly with system dependencies without requiring network access
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #342
Problem
When building lolly with system dependencies, the build fails
because add_requires() had system=false which forced downloading
packages even without network access.
Solution
Changed system=false to system=true in all add_requires() calls:
This allows building lolly using system-installed packages
without requiring network access.