Repository navigation
fix(glm5): align FP8 precision and preserve reasoning tool calls #1657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
shihaobai
wants to merge
14
commits into
main
Choose a base branch
from
bsh/glm53_fix
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
ea2b4db
fix: parse GLM tool calls inside reasoning
shihaobai e8c8bc8
fix: harden GLM reasoning and XML tool parsing
shihaobai 637c079
refactor: keep GLM tool parsing within existing detectors
shihaobai 6c902a0
refactor: separate thinking policy from reasoning state
shihaobai bdda980
refactor: simplify GLM parser state and argument handling
shihaobai 710118e
fix(glm5): align indexer, routing and mHC numerics
shihaobai 92d580e
fix(glm5): match training post rounding and close precision tests
shihaobai aee915e
fix(moe): honor UE8M0 scales in Triton expert activations
shihaobai 3e7a521
fix(glm5): align eager SwiGLU, W2 routing and mHC post with training
shihaobai 35f71e9
fix(glm5): revert FFN numerical alignment for isolated indexer ablation
shihaobai 6d219d3
feat(glm5): add opt-in BF16 indexer precision ablation
shihaobai bb6833d
feat(fp8): decouple activation scale format from checkpoint weights
shihaobai a139d3f
refactor(glm5): trim precision fixes to FP8 and prefill combine
shihaobai 2e042f4
Merge PR #1651: preserve GLM tool calls inside reasoning
shihaobai File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Handle
shared_expert_outputin the Triton implementation.If a caller supplies
shared_expert_outputthroughFusedMoeWeight.expertswith a Triton implementation, this call raisesTypeError:FuseMoeTriton._fused_expertsdoes not accept the forwarded keyword. The GLM5 non-EP branch currently avoids this call, but the extended weight API accepts the value. Add the shared output in the Triton path, or reject it explicitly at the weight API boundary. (raw.githubusercontent.com)