fix stream fc for qwen3_coder

[shihaobai]

No description provided.

[gemini-code-assist]

Code Review

This pull request introduces XML tool-call streaming parsing support for Qwen3-Coder in lightllm/server/function_call_parser.py by adding regexes, helper methods for monotonic JSON argument building, and updating the streaming increment parser. The review feedback identifies three critical issues: first, implicitly closed parameters are incorrectly treated as unclosed, which prematurely breaks the streaming loop; second, parallel tool calls can trigger an IndexError because state arrays are not dynamically resized as the tool ID increments; and third, fallback logic for non-string parameter conversion can output invalid JSON instead of properly serialized values.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[gemini-code-assist]

In streaming scenarios with multiple parameters, a parameter can be implicitly closed when a subsequent parameter starts (e.g., matching (?=<parameter=)) or when the function block closes (e.g., matching (?=</function>)). In these cases, match.group(3) is empty, so closed is incorrectly evaluated as False. This causes the loop to break early, completely ignoring any subsequent parameters. Checking the remaining text for lookahead matches or close_object ensures that implicitly closed parameters are correctly processed and the loop continues to subsequent parameters.

            remaining = partial_body[match.end():]
            closed = (
                match.group(3) == "</parameter>"
                or remaining.startswith("<parameter=")
                or remaining.startswith("</function>")
                or close_object
            )
            if not closed:
                param_value = self._strip_partial_xml_suffix(param_value)

[gemini-code-assist]

When processing parallel tool calls, self.current_tool_id is incremented inside the func_matches loop. For any subsequent matches, completed_tool_id will exceed the current bounds of self.prev_tool_call_arr and self.streamed_args_for_tool, leading to an IndexError and crashing the server. Calling self._ensure_qwen3_stream_state(completed_tool_id) inside the loop ensures the state arrays are dynamically resized to accommodate parallel tool calls.

Suggested change

	completed_tool_id = self.current_tool_id
	try:
	parsed_args = json.loads(item.parameters)
	except json.JSONDecodeError:
	parsed_args = {}
	self.prev_tool_call_arr[completed_tool_id] = {
	"name": item.name,
	"arguments": parsed_args,
	}
	completed_tool_id = self.current_tool_id
	self._ensure_qwen3_stream_state(completed_tool_id)
	try:
	parsed_args = json.loads(item.parameters)
	except json.JSONDecodeError:
	parsed_args = {}
	self.prev_tool_call_arr[completed_tool_id] = {
	"name": item.name,
	"arguments": parsed_args,
	}

[gemini-code-assist]

When closed is True, the parameter value is complete. If the parameter type is non-string (e.g., boolean, integer, object), and the value fails to convert or has a different representation (like True vs true), the startswith check will fail and append the raw param_value directly. This can result in invalid JSON (e.g., {"param": True} or {"param": abc}). Directly appending json.dumps(converted, ensure_ascii=False) guarantees valid JSON output.

Suggested change

	elif closed:
	converted = self._convert_param_value(param_value, param_name, param_config, func_name)
	converted_json = json.dumps(converted, ensure_ascii=False)
	if converted_json.startswith(param_value):
	parts.append(converted_json)
	else:
	parts.append(param_value)
	elif closed:
	converted = self._convert_param_value(param_value, param_name, param_config, func_name)
	parts.append(json.dumps(converted, ensure_ascii=False))