fix: add sealed secrets#503
Open
MoeexT wants to merge 5 commits into
Open
Conversation
- Makefile: move args file cleanup from datamate target to install target - Makefile: milvus can now source /tmp/datamate-helm-args.sh before cleanup - scripts/k8s/node-setup.sh: export HELM_MILVUS_TOLERATIONS in skip path - deployment/helm/milvus/values.yaml: default tolerations to [] (no isolation) Root cause: /tmp/datamate-helm-args.sh deleted in datamate-k8s-install, before milvus-k8s-install could source it. When node isolation was active, milvus received no tolerations and pods couldn't schedule on tainted nodes. Also: Milvus chart had hardcoded tolerations (anchored YAML reference), causing SchedulingDisabled even without node isolation configured. Now supports all 4 scenarios: - Open source + no isolation → no tolerations, any node (default) ✅ - Open source + isolation → tolerations applied to datamate + milvus ✅ - Commercial + no isolation → no tolerations ✅ - Commercial + isolation → tolerations for sealed-secrets + datamate + milvus ✅ Args file lifecycle: node-setup.sh creates → sealed-secrets sources → datamate sources → milvus sources → install target cleans up
- scripts/k8s/node-setup.sh: add etcd.tolerations and minio.tolerations - Sub-charts don't inherit parent chart tolerations in Helm Symptom: milvus-etcd and milvus-minio stuck Pending with '0/1 nodes are available: 1 node(s) had untolerated taint(s)' when node isolation is active Root cause: --set-string tolerations[0]... only sets milvus main chart, but etcd and minio are sub-charts with their own tolerations: [] Fix: generate --set-string etcd.tolerations[0]... and --set-string minio.tolerations[0]... alongside milvus tolerations Note: milvus-standalone CrashLoopBackOff is a Milvus v2.6.5 ARM64 bug (goroutine deadlock in streaming_node_manager), NOT node isolation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.