feat: seal feedback element - #242
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
🟡 Changes recommended
Persisted identity data may be exposed for signed-out users, component coverage is missing, and formatting currently fails lint.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Adds responsive Seal of Reliability feedback links with Google Form identity prefilling. Vercel React best-practices guidance was applied.
Changes:
- Adds desktop and mobile feedback controls to Seal pages.
- Prefills known user name and email.
- Adds localized labels and URL-builder tests.
File summaries
| File | Description |
|---|---|
src/app/components/SealFeedbackButton.tsx |
Implements responsive feedback controls. |
src/app/utils/seal-feedback-url.ts |
Builds Google Form prefill URLs. |
src/app/utils/seal-feedback-url.spec.ts |
Tests URL generation. |
src/app/screens/Feed/components/FeedReliabilityView.tsx |
Adds feedback to detail pages. |
src/app/[locale]/seal-of-reliability/how-it-is-calculated/components/HowItIsCalculatedPage.tsx |
Adds feedback to calculation page. |
src/app/[locale]/seal-of-reliability/components/SealOfReliabilityDescriptionPage.tsx |
Adds feedback to description page. |
messages/en.json |
Adds English labels. |
messages/fr.json |
Adds French labels. |
Review details
- Files reviewed: 8/8 changed files
- Comments generated: 3
- Review effort level: Balanced
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| const feedbackUrl = useMemo( | ||
| () => | ||
| isMounted ? buildSealFeedbackUrl({ name, email }) : SEAL_FEEDBACK_URL, | ||
| [isMounted, name, email], |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
|
*Lighthouse ran on https://mobilitydatabase-k182ow0l4-mobility-data.vercel.app/ * (Desktop)
*Lighthouse ran on https://mobilitydatabase-k182ow0l4-mobility-data.vercel.app/feeds * (Desktop)
*Lighthouse ran on https://mobilitydatabase-k182ow0l4-mobility-data.vercel.app/feeds/gtfs/mdb-2126 * (Desktop)
*Lighthouse ran on https://mobilitydatabase-k182ow0l4-mobility-data.vercel.app/feeds/gtfs_rt/mdb-2585 * (Desktop)
*Lighthouse ran on https://mobilitydatabase-k182ow0l4-mobility-data.vercel.app/feeds/gbfs/gbfs-flamingo_porirua * (Desktop)
|
|
LGTM! |
Summary:
closes #214
Expected behavior:
On the seal description page, seal how it is calculated page and seal detail pages a feedback prompt will appear
When the logged in user clicks on the google form, it will prefill their name and email address as they navigate into a different browser
Testing tips:
Go to any of the pages mentioned above as try to submit feedback: light mode dark mode, large / small screens
Please make sure these boxes are checked before submitting your pull request - thanks!
yarn testto make sure you didn't break anything