Skip to content

feat: seal feedback element - #242

Merged
Alessandro100 merged 7 commits into
mainfrom
feat/214-seal-feedback-form
Sep 17, 2026
Merged

Alessandro100 merged 7 commits into
mainfrom
feat/214-seal-feedback-form

Conversation

@Alessandro100

@Alessandro100 Alessandro100 commented Sep 17, 2026 •

Copy link
Copy Markdown
Contributor

Summary:

closes #214

Expected behavior:

On the seal description page, seal how it is calculated page and seal detail pages a feedback prompt will appear

  • Large screen: On the right middle
  • Smaller screens: On the bottom right as FAB

When the logged in user clicks on the google form, it will prefill their name and email address as they navigate into a different browser

Testing tips:

Go to any of the pages mentioned above as try to submit feedback: light mode dark mode, large / small screens

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with yarn test to make sure you didn't break anything
  • Add or update any needed documentation to the repo
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)
Screenshot 2026-09-17 at 07 17 38 Screenshot 2026-09-17 at 07 38 31 Screenshot 2026-09-17 at 07 38 44 Screenshot 2026-09-17 at 07 38 48 Screenshot 2026-09-17 at 07 38 55

@Alessandro100
Alessandro100 requested a balanced review from Copilot September 17, 2026 11:44
@Alessandro100 Alessandro100 self-assigned this Sep 17, 2026
@vercel

vercel Bot commented Sep 17, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
mobilitydatabase-web Ready Ready Preview Sep 17, 2026 2:47pm UTC

Request Review

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Persisted identity data may be exposed for signed-out users, component coverage is missing, and formatting currently fails lint.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

Adds responsive Seal of Reliability feedback links with Google Form identity prefilling. Vercel React best-practices guidance was applied.

Changes:

  • Adds desktop and mobile feedback controls to Seal pages.
  • Prefills known user name and email.
  • Adds localized labels and URL-builder tests.
File summaries
File Description
src/app/components/SealFeedbackButton.tsx Implements responsive feedback controls.
src/app/utils/seal-feedback-url.ts Builds Google Form prefill URLs.
src/app/utils/seal-feedback-url.spec.ts Tests URL generation.
src/app/screens/Feed/components/FeedReliabilityView.tsx Adds feedback to detail pages.
src/app/[locale]/seal-of-reliability/how-it-is-calculated/components/HowItIsCalculatedPage.tsx Adds feedback to calculation page.
src/app/[locale]/seal-of-reliability/components/SealOfReliabilityDescriptionPage.tsx Adds feedback to description page.
messages/en.json Adds English labels.
messages/fr.json Adds French labels.
Review details
  • Files reviewed: 8/8 changed files
  • Comments generated: 3
  • Review effort level: Balanced

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/app/components/SealFeedbackButton.tsx Outdated
Comment thread src/app/components/SealFeedbackButton.tsx Outdated
Comment on lines +49 to +52
const feedbackUrl = useMemo(
() =>
isMounted ? buildSealFeedbackUrl({ name, email }) : SEAL_FEEDBACK_URL,
[isMounted, name, email],
Alessandro100 and others added 2 commits September 17, 2026 07:56
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@github-actions

github-actions Bot commented Sep 17, 2026 •

Copy link
Copy Markdown

*Lighthouse ran on https://mobilitydatabase-k182ow0l4-mobility-data.vercel.app/ * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance Accessibility Best Practices SEO
🟢 97 🟢 94 🟢 96 🟢 100

*Lighthouse ran on https://mobilitydatabase-k182ow0l4-mobility-data.vercel.app/feeds * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance Accessibility Best Practices SEO
🟠 83 🟠 87 🟢 96 🟢 100

*Lighthouse ran on https://mobilitydatabase-k182ow0l4-mobility-data.vercel.app/feeds/gtfs/mdb-2126 * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance Accessibility Best Practices SEO
🔴 40 🟢 94 🟢 96 🟢 100

*Lighthouse ran on https://mobilitydatabase-k182ow0l4-mobility-data.vercel.app/feeds/gtfs_rt/mdb-2585 * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance Accessibility Best Practices SEO
🟢 91 🟠 84 🟢 96 🟢 100

*Lighthouse ran on https://mobilitydatabase-k182ow0l4-mobility-data.vercel.app/feeds/gbfs/gbfs-flamingo_porirua * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance Accessibility Best Practices SEO
🟢 98 🟢 94 🟢 96 🟢 100

@emmambd
emmambd requested a review from abigailmbd September 17, 2026 12:34
@emmambd

emmambd commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

LGTM!

@abigailmbd abigailmbd left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Alessandro100
Alessandro100 merged commit 0ba11ff into main Sep 17, 2026
4 checks passed

This branch was successfully deployed

1 active deployment
Preview — f8a2c578 Deployed Sep 17, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants