You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The Compliant criterion showed an error count and a link out to the HTML report. It now lists the error codes behind the verdict, using the new GET /v1/gtfs_feeds/{id}/validation_reports endpoint.
Regenerated types.ts, added getGtfsFeedValidationReports, and fetched it alongside the three existing seal endpoints.
Errors only. Each row carries the code, the GTFS file it applies to, a one-line description and how many times it was raised. The wording comes from the validator's own rules index (gtfs-validator.mobilitydata.org/rules.json), cached 24h server side, falling back to the humanised code when a rule is missing.
Errors carried over from earlier datasets are summarised in one line; new ones are marked, so it is clear whether a failure is current.
Links to download the dataset (URL built like buildRoutesUrl) and to open the validation report. Both stay when the criterion passes.
"The latest validation report has X errors" now counts distinct codes rather than occurrences, so the sentence and the list agree.
Notes:
The panel is a Server Component, so none of this ships client JS.
One extra API call, issued in parallel with the other seal endpoints and cached 6 hours. The rules index is fetched server side only.
The endpoint is tagged beta and lives on the API's main branch, not a tagged release: running yarn generate:api-types today would revert types.ts.
Some feeds come back with latest: null and is_latest false on every entry (e.g. mdb-3215). The model falls back to the most recently validated report, but this looks worth fixing API side.
Testing tips:
/feeds/gtfs/{id}/seal-of-reliability on a failing GTFS feed: error list, carried/new line, both links.
A feed whose latest dataset is clean: no list, links still present.
yarn test covers the model, the rules parser and the compliance summary.
Run the unit tests with yarn test to make sure you didn't break anything
Add or update any needed documentation to the repo
Format the title like "feat: [new feature short description]"
Linked all relevant issues
Include screenshot(s) showing how this pull request works and fixes the issue(s)
Thanks for opening this pull request! You're awesome. We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix. Examples of titles with semantic prefixes:
fix: Bug with ssl network connections + Java module permissions.
feat: Initial support for multiple @PrimaryKey annotations.
docs: update RELEASE.md with new process
To get this PR to the finish line, please do the following:
@cka-y I'm having trouble finding examples of the cases you've screenshot but the screenshots themselves look great, and I found one instance of not_evaluated where there were no previous validation reports to reference and the result looks great. LGTM!
It means that the error existed in previous datasets. If the 3 errors were new it would say '3 new errors in this dataset'. My rationale behind this information is that it might be valuable for producer to know if the error is newly introduced in the error state dataset (which might be different from the latest dataset) or existed before so they can better determine which part of their pipeline it came from. Happy to remove it if it has no value cc: @emmambd
This made sense to me upon reading it so I'd keep it in at this stage (given when you look at the dataset history, it's clear the newest validation report is unknown)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cka-y
changed the title
source: /tdg-84170
Remove the divider line at the bottom if there are no errors to display
cc: @davidgamez - the most errors i could find on prod is 6
Alessandro100
left a comment
Summary:
The Compliant criterion showed an error count and a link out to the HTML report. It now lists the error codes behind the verdict, using the new
GET /v1/gtfs_feeds/{id}/validation_reportsendpoint.types.ts, addedgetGtfsFeedValidationReports, and fetched it alongside the three existing seal endpoints.gtfs-validator.mobilitydata.org/rules.json), cached 24h server side, falling back to the humanised code when a rule is missing.buildRoutesUrl) and to open the validation report. Both stay when the criterion passes.Notes:
mainbranch, not a tagged release: runningyarn generate:api-typestoday would reverttypes.ts.latest: nullandis_latestfalse on every entry (e.g.mdb-3215). The model falls back to the most recently validated report, but this looks worth fixing API side.Testing tips:
/feeds/gtfs/{id}/seal-of-reliabilityon a failing GTFS feed: error list, carried/new line, both links.A feed whose latest dataset is clean: no list, links still present.
yarn testcovers the model, the rules parser and the compliance summary.Run the unit tests with
yarn testto make sure you didn't break anythingAdd or update any needed documentation to the repo
Format the title like "feat: [new feature short description]"
Linked all relevant issues
Include screenshot(s) showing how this pull request works and fixes the issue(s)
In grace period:
Failure
Pass
