Conversation
cka-y
marked this pull request as ready for review
July 23, 2026 15:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Extends
rebuild_missing_validation_reports(functions-python/tasks_executor) by adding optional filters so we can re-validate a historical window against the prod validator. Closes #1762.filter_downloaded_after/filter_downloaded_before: ISO-date window ondownloaded_at.filter_validator_version_prefix: target datasets lacking any report matching the prefix (e.g."8."), not just a non-exact version.include_all_datasets: consider all datasets of a feed, not just the latest.All default to preserve existing behavior. README + unit tests updated.
Expected behavior:
Dry run reports the count of published feeds' datasets in the window missing an
8.*report; non-dry run triggers a validation workflow per candidate against prod and writes the reports. Responseparamsecho the applied filters.Testing tips:
Fields must be nested under
"payload". Dry run first:{ "task": "rebuild_missing_validation_reports", "payload": { "dry_run": true, "filter_downloaded_after": "2026-03-01", "filter_downloaded_before": "2026-06-01", "filter_validator_version_prefix": "8.", "include_all_datasets": true, "validator_endpoint": "https://gtfs-validator-web-mbzoxaljzq-ue.a.run.app" } }Check
paramsecho your filters and reviewtotal_candidates, then flipdry_runtofalseto trigger.include_all_datasets: trueis what covers all datasets in the window (else latest-only).operational_status(default published) with an exclusive upper bound, so it won't match a rawdownloaded_at BETWEENquery.8.*datasets are skipped. Try"limit": 10for a small batch first.Notes for testers:
operational_status = 'published', and an exclusive upper bound — so it won't match a rawSELECT ... FROM gtfsdataset WHERE downloaded_at BETWEEN ...count.8.*report is excluded."limit": 10for a small end-to-end batch first.Please make sure these boxes are checked before submitting your pull request - thanks!
./scripts/api-tests.shto make sure you didn't break anything