Repository navigation
Name every function by a SQL name it deploys - #169
Merged
estebanzimanyi merged 1 commit intoOct 3, 2026
Merged
Conversation
state_deployed_sqlfn sets a function's sqlfn to the name of its first signature when its signatures carry several names and none is its tag, and the signature carrying that name drops the sqlName that restates it; the first signature is the tagged wrapper's, as attach_sqlfn_map lists them. A function one of whose signatures carries its tag keeps it, as before. test_sqlfn_deployed.py states the case, its catalog check asks of every function that one of its signatures carries its sqlfn, and its adjacency check reads the class-prefixed name tboxAdjacent MobilityDB gives the operator function. Witness: since MobilityDB deploys the FromText readers beside the type inputs, floatset_in carries the signatures floatset_in and floatsetFromText under Set_in, tagged intset_in(), so its sqlfn read intset_in, a sibling's name, and so did 61 other functions (tfloat_in read tint_in, temporal_tagg_finalfn tCount, tpointseq_from_base_tstzset tint). The pytest workflow failed on master's catalog: test_per_type_functions_carry_their_own_name on floatset_in, and test_backing_tags_keep_their_family_name on adjacent_tbox_tnumber, whose sqlfn MobilityDB 762b3501cc renamed to tboxAdjacent. Why: a binding names a function by its sqlfn, so these 62 were offered under a name that answers another type. Measured: over MobilityDB 985fdb26b7 the catalog changes the sqlfn of those 62 functions and nothing else; pytest tests/ answers 459 passed and 11 skipped with MDB_SRC_ROOT set, where master answers 2 failed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
state_deployed_sqlfn sets a function's sqlfn to the name of its first signature when its
signatures carry several names and none is its tag, and the signature carrying that name
drops the sqlName that restates it; the first signature is the tagged wrapper's, as
attach_sqlfn_map lists them. A function one of whose signatures carries its tag keeps it, as
before. test_sqlfn_deployed.py states the case, its catalog check asks of every function
that one of its signatures carries its sqlfn, and its adjacency check reads the
class-prefixed name tboxAdjacent MobilityDB gives the operator function.
Witness: since MobilityDB deploys the FromText readers beside the type inputs, floatset_in
carries the signatures floatset_in and floatsetFromText under Set_in, tagged intset_in(), so
its sqlfn read intset_in, a sibling's name, and so did 61 other functions (tfloat_in read
tint_in, temporal_tagg_finalfn tCount, tpointseq_from_base_tstzset tint). The pytest
workflow failed on master's catalog: test_per_type_functions_carry_their_own_name on
floatset_in, and test_backing_tags_keep_their_family_name on adjacent_tbox_tnumber, whose
sqlfn MobilityDB 762b3501cc renamed to tboxAdjacent.
Why: a binding names a function by its sqlfn, so these 62 were offered under a name that
answers another type.
Measured: over MobilityDB 985fdb26b7 the catalog changes the sqlfn of those 62 functions
and nothing else; pytest tests/ answers 459 passed and 11 skipped with MDB_SRC_ROOT set,
where master answers 2 failed.