Open
Conversation
CryptoSwift: 1.3.3 -> 1.4.2 ArgumentParser: 0.3.1 -> 1.0.3 Signed-off-by: Danny Gilbert <spydercapriani@gmail.com>
Signed-off-by: Danny Gilbert <spydercapriani@gmail.com>
Allow consumers to specify different logsDir Signed-off-by: Danny Gilbert <spydercapriani@gmail.com>
Allow consumers to inject modified LogFinders Signed-off-by: Danny Gilbert <spydercapriani@gmail.com>
spydercapriani
requested review from
CognitiveDisson,
aleksandergrzyb,
ecamacho and
polac24
as code owners
Author
|
Example: This will parse the latest package resolution log for the project. |
This reverts commit 5e36c73.
Signed-off-by: Danny Gilbert <spydercapriani@gmail.com>
Return list of file URLs for log dir. Signed-off-by: Danny Gilbert <spydercapriani@gmail.com>
Offer filtering for logs newer than specifed date Signed-off-by: Danny Gilbert <spydercapriani@gmail.com>
Path is case sensitive for tests but not in real world use Signed-off-by: Danny Gilbert <spydercapriani@gmail.com>
Signed-off-by: Danny Gilbert <spydercapriani@gmail.com>
Collaborator
PatrikBillgren
left a comment
PatrikBillgren
left a comment
There was a problem hiding this comment.
Thanks for submitting the PR! I have a few comments and questions. I also see there are a few Swiftlint warnings
| ) | ||
|
|
||
| @Option(name: .long, help: "Type of .xactivitylog file to look for.") | ||
| var logs: LogType = .build |
Collaborator
There was a problem hiding this comment.
Suggestion:
Rename this variable to logType . (Same for ManifestCommand.swift and ParseCommand.swift)
| abstract: "Dumps the xcactivitylog file into a JSON document" | ||
| ) | ||
|
|
||
| @Option(name: .long, help: "Type of .xactivitylog file to look for.") |
Collaborator
There was a problem hiding this comment.
What do you think about printing the available option values here as well to make it easier for the user?
|
|
||
| } | ||
|
|
||
| public func findLatestLogsWithLogOptions(_ logOptions: LogOptions) throws -> [URL] { |
Collaborator
There was a problem hiding this comment.
I see this function is not used, was it supposed to be part of a refactor?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Opens up the parsing feature to more LogTypes.
Idea behind this approach is to make it easier to parse things like Package logs so as to potentially allow metric collection around dependencies. For example, Package + Build Logs can provide a deeper picture of what developement cycle looks like since package resolution happen before builds take place but aren't necessarily being accounted for.