Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
stephantul
approved these changes
May 21, 2026
Contributor
stephantul
left a comment
stephantul
left a comment
There was a problem hiding this comment.
Approval contingent on discussion, maybe i misunderstood
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the MCP's serve non-blocking for model loading (as well as direct indexing from a given path). This should hopefully resolve #133, or at least help since the model download no longer blocks the initial startup for Semble.
force_downloadis also set to False for the model so we don't check HF everytime if the model is already cached. Tested locally by deleting my own cached model and it makes the server respond in ~0.3 seconds instead of ~5 seconds (on very very fast internet).