Skip to content

test(agent-tools): let the failing bash child flush its output #589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
1anZhang merged 1 commit into from
Nov 4, 2026
Merged

test(agent-tools): let the failing bash child flush its output #589

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/agent-tools/test/desktop/ptc-child-uncapped.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,8 +283,10 @@ describe('bash child calls', () => {

it('keeps the status line after the whole output of a failing command', async () => {
const tool = new LocalBashTool(workspace, undefined, { mode: 'off' });
// process.exit() would drop stdout still queued on the POSIX pipe, so the
// child sets exitCode and lets Node flush the 400 rows before exiting.
const command = nodeCommand(
`for(let i=0;i<400;i++) console.log('row-'+i+'-'+'x'.repeat(90)); process.exit(3)`,
`for(let i=0;i<400;i++) console.log('row-'+i+'-'+'x'.repeat(90)); process.exitCode = 3`,
);
const result = await tool.execute(CHILD, { command });

Expand Down
Loading