Repository navigation
fix(local-runtime): stop leaking stack traces through HTTP JSON - #568
Merged
Merged
Conversation
CodeQL js/stack-trace-exposure on main: json() was a sink for Error-derived payloads. Drop stack keys (and Error instances) in the JSON replacer, stop embedding error.stack in TaskError details, return stable client text for 5xx / feishu questionnaire failures, and keep only short single-line validation messages on 4xx cron responses.
hetaoBackend
marked this pull request as ready for review
October 31, 2026 01:38
7723qqq
added a commit
to 7723qqq/minimax-code
that referenced
this pull request
Nov 4, 2026
…-AI#568 stack-leak fix Takes upstream/main @ a5a05c2 for the v1 runtime, including fix(local-runtime): stop leaking stack traces through HTTP JSON (MiniMax-AI#568). Fork capabilities re-applied on top: bun:sqlite drivers (better-sqlite3 loader excluded), Bun.spawn wrappers, the runtime-locale i18n bridge (locale.ts resolver, channel receipts, permission reason catalogs with locale threading in checkers/facade), the lifecycle-frame classification in sse-collector, embedded-assets skill seeding, and Bun's autoSelectFamily pinnedLookup shape. Tests ported to Bun mechanics (beforeAll mock registration with afterAll restore, real-timer waitFor replacing fake timers, preload `mocked`). Three Windows-only opt-out assertions reproduce with verbatim upstream code and stay accepted pending POSIX CI. Deviation ledger: g:\mimimaxcode\sync-0.7.2-review\bun-porting-deviations.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Clears the open CodeQL alert
js/stack-trace-exposureonmain(packages/local-runtime/src/api/host-helpers.tsjson()sink). Stack-shaped and Error-derived payloads could reach HTTP clients through that helper and throughTaskError.details.json()uses a replacer that dropsstackkeys and turnsErrorvalues into{ name, message }.normalizeTaskErrorno longer embedserror.stackindetails(TaskError is returned over HTTP).QUESTIONNAIRE_SUBMIT_FAILEDcode; the user-facing toast was already generic.Invalid cron scheduleand logs the detail server-side.Validation
pnpm typecheckPASS on this branch (Node 24.22.2).JSON.stringifywith the new replacer omitsdetails.stackand serializes nestedErrorwithout frames.Publication and contribution checks
Need help on this PR? Tag
@codesmith-botwith what you need.