fix: test provider add --use and expose model token limits - #169
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Fixes #157.
mcode provider add --usenow tests the first model through the existing candidate transaction, then saves and selects it. A failed connection test exits nonzero with an explicit no-save message and leaves the provider configuration and default model unchanged. Adding without--usestill saves without testing or selecting a model.Fixes #161. Add
--context-limitand--output-limitwith positive safe-integer validation. Either can be supplied independently; the values apply to every repeated--model. Persisted limits are exposed ascontextLimitandmaxOutputTokensinprovider list --json. Update both READMEs and the model examples. No provider-update command or low-level configuration writer changes.Validation
git diff --check.pnpm verifyfull profile on clean committed HEADe6384134d986280ae6b175392b3338761e5b34e6: all 14 macOS gates, including source export, capability tests, artifact/smoke/BYOK checks, permission policy and sandbox tests.Publication and contribution checks
Maintainer handoff
Publication scope or license changes: none.
Shared-source port: pending.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.