fix: enforce wrapped bash rules and scrub provider credentials - #167
Merged
Merged
Conversation
This was referenced Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
A transparent wrapper such as
nohup npm publishcould evadedeny npm publish:*while matchingallow npm:*. Deny, ask and allow rules now share the same raw and wrapper-stripped command matching, preserving their precedence in default, auto and bypass static evaluation.Permission rule updates retain the host-owned
isFileprobe so local-script classification does not change after a grant or revocation. Bash environment scrub also removesMCODE_PROVIDER_API_KEYand itsINPUT_alias. The scrub list remains precise: custom key names, provider model/URL settings and legitimate GH/npm tokens keep their existing behavior; off mode and strict allowlist semantics are unchanged.Closes #150. Closes #151. Closes #153.
Validation
git diff --checkandpnpm check:source: PASS.pnpm verifyfull profile: PASS on clean committed HEAD0e68219ba442ae55a3172c8a8da425bd6b4ce386, macOS arm64, Node 26.4.0 (84 seconds). All 14 gates passed, including 3,495 capability tests, 115 permission-facade tests, 48 sandbox tests, source export, typecheck, build, artifact checks, smoke and offline BYOK. The release-tools suite reports its existing platform-specific skip (20 passed, 1 skipped).--api-key-envnames remain outside the fixed scrub list.Publication and contribution checks
release/public-source.json; both are declared intest/vitest-suites.jsonfor the cross-platform capability gate.Maintainer handoff
Publication scope: two regression test files only; no license changes.
Shared-source port: pending.