test: isolate offline smoke children from ambient proxies - #166
Merged
Merged
Conversation
2 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Fixes #154. Offline smoke children inherited host proxy variables, allowing CLI proxy setup to replace the preloaded fetch mock and trigger the network-deny audit during catalog refresh.
Clear uppercase and lowercase HTTP_PROXY, HTTPS_PROXY, ALL_PROXY and NO_PROXY only in the smoke fixture's child environment. Add six real CLI regression cases with an unreachable synthetic proxy; each checks provider output and the locally handled catalog request. Production networking and the network-deny hook are unchanged.
Validation
pnpm test:smokepassed with proxy variables removed and with all six proxy variables set tohttp://127.0.0.1:9: 14 tests passed in each run.git diff --check,pnpm check:sourceandpnpm check:tsconfigpassed.pnpm verifyfull profile passed all 14 gates on clean commita1c48d37cc7b3fdf38a9c59cc2ac239c8842a655(macOS arm64, Node 26.4.0, pnpm 9.12.0).Publication and contribution checks
Maintainer handoff
Publication scope or license changes: none.
Shared-source port: not needed; this changes the public distribution's smoke harness only.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.