fix: preserve literal dollar sequences in replace-all edits - #165
Merged
Merged
Conversation
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Fixes #155. Bulk edits now insert replacement text literally:
$$,$&, dollar-backtick, and dollar-apostrophe remain unchanged instead of collapsing dollars, reinserting the match, or duplicating surrounding file content.Use a replacement callback in the shared replace-all helper. Add 12 regression cases covering helper output and occurrence counts, actual
LocalEditToolfile writes with multiple matches, and single-edit controls. Register the test in the capability suite and regenerate the public source inventory.Validation
git diff --check: passed.pnpm verifyon clean commit9a35236fdc2ca1944c8e3b6eddbd7a50fee8ac22: all 14 full-profile gates passed on macOS arm64, Node.js 26.4.0 (including source export, typecheck, build, capability regressions, smoke, offline BYOK, policy and sandbox).Publication and contribution checks
release/public-source.jsonand is declared intest/vitest-suites.json.Maintainer handoff
No publication scope or license changes. Shared-source port: pending.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.