fix: require separate consent for automatic telemetry uploads - #148
Merged
Merged
Conversation
SaladDay
force-pushed
the
codex/automatic-telemetry-consent
branch
from
September 18, 2026 16:03
d9e2047 to
1e183e6
Compare
Default runtime metrics and diagnostics to off, honor global opt-outs, and recheck diagnostic consent before sending. Include privacy regressions and the generated source and test inventories.
Expose all three telemetry channel settings, scope previews to usage events, and document independent opt-ins and automatic diagnostics. Include the matching CLI regression test.
SaladDay
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Runtime performance metrics and automatic error reports could upload without separate user consent. Require independent, default-off
telemetry.metricsandtelemetry.diagnosticsopt-ins, while keepingtelemetry.enabledscoped to usage events.MCODE_DISABLE_TELEMETRYandDO_NOT_TRACKoverride all three channels.Keep the implementation small: business-source changes total 93 lines (+77/-16), down from 466 in the original implementation. Organize the PR into two commits: consent enforcement and regression tests; channel status, usage preview messaging, and documentation. Existing login, model requests, local observability, and user-submitted feedback retain their behavior.
Disabled TUI incidents are stored as local-only files and are not automatically uploaded. LLM diagnostics require consent before buffering and again before sending; TUI diagnostics recheck consent after asynchronous authentication.
mcode telemetry statusdisplays all three channel settings, andpreviewdescribes usage events only. Configuration changes require restarting MCode.Validation
pnpm verify, full profile, Linux x64, Node 22.22.2: all 13 applicable gates passed on0634d7338ef569377e2bb51b962d084cf8270993. The final two-commit head1e183e6b877474725edfae3caa57888fdff437adhas exactly the same Git tree (73a0f1a2f76551672bfa5dee3f79043c5a8948cf); only commit history was reorganized, so the full suite was not rerun for this history-only update.git diff --checkpassed.Publication and contribution checks
release/public-source.json; new tests are declared intest/vitest-suites.jsonwhere applicable.Maintainer handoff
Publication scope or license changes: no license changes; the inventory adds the shared telemetry policy and a metrics privacy test. English telemetry/capability documentation is updated; shared README content is unchanged.
Shared-source port: pending.