Repository navigation
chore: ignore credential files - #76
Merged
Merged
Conversation
A plugin that asks for an API key must not be able to commit one. The key files stay outside the checkout, but a .env written next to the plugin would have been tracked by default.
hetaoBackend
approved these changes
Nov 3, 2026
hetaoBackend
left a comment
hetaoBackend
left a comment
Collaborator
There was a problem hiding this comment.
Approved after exact-head review: this head only adds credential-file ignore rules to the repository .gitignore; no executable/plugin/host-contract code changes. Exact head ae6e6f7 has successful GitHub check suites and is mergeable/clean.
antianqi
added a commit
to antianqi/MiniMax-Code-Plugins-1
that referenced
this pull request
Nov 3, 2026
Bring PR MiniMax-AI#62 up to date with upstream/main so the branch stops showing as CONFLICTING and can be reviewed as a normal diff. Upstream changes picked up (merge-base 39ddd2c -> 01c44b6): - 0125d0f: rename plugins/stevenjj33/web-research -> plugins/stevenjj33/web-search - 01c44b6: chore: ignore credential files (MiniMax-AI#76) Conflict resolution: - .gitignore: both sides appended a new block to the same base. Kept both. Upstream's credential rules (.env, secrets/, credentials.json, *.pem, *.p12) stay first; the branch's stale-widget-backup rule (*.bak-r16) follows in its own commented block. No rule is dropped and no rule is duplicated. Validation: - git status shows no remaining unmerged paths after the merge. - .gitignore written with LF endings and UTF-8 without BOM, matching the file already in the tree. - The renamed web-search tree matches upstream/main byte for byte; git recorded it as a pure rename with no content conflict. Test evidence: - No plugin source files were touched by this merge, so the mcode-island suites are unaffected. The branch tip before the merge was a3961c1, whose own run was smoke 203 pass / 7 warn / 0 fail, tracker 115 pass, substep 139 pass, and 27 negative injections all failing as designed. Design compliance: - One commit, one purpose: this commit carries the upstream sync only. - No unrelated files are included. Untracked working-tree files from another line of work (jianying plugin, PR comment drafts) are deliberately left out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
.gitignoregrows a block that keeps credential files out of the checkout:Why
A plugin that asks the user for an API key must not be able to commit one. The key itself is written outside the checkout (
~/.config/agents/<name>.json, mode 0600, or an environment variable), so the exposure is narrow today — but a.envwritten next to the plugin, or acredentials.jsonproduced by a setup step, would be tracked by default. This block is the last line of defence for that..env.examplestays trackable on purpose: a template is exactly the file a plugin needs to publish.Verification
git check-ignoremarks.env,credentials.jsonand*.pemas ignored, and.env.exampleas trackable.A note on the patterns
They are deliberately specific. A broader
*secret*rule would have ignoredplugins/Fectivnfy112357/github-explore/skills/github-explore/scripts/tests/test_secret_redaction.py, which is a source file and not a credential.