Repository navigation
Keep old Base Metals items when upgrading 1.12 worlds - #507
Merged
SkyBlade1978 merged 1 commit intoOct 19, 2026
Merged
SkyBlade1978 merged 1 commit into
SkyBlade1978 merged 1 commit into
Conversation
SkyBlade1978
merged commit Oct 19, 2026
197a4b3
into
MinecraftModDevelopmentMods:master-1.12
5 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes older Base Metals worlds losing Mercury blocks, carbon powder, iron nuggets and metal door items when upgraded to 1.12.2.
The missing-mapping handlers now run correctly and cover all 20 historical item names plus the old Mercury block name. A data fixer rewrites old stack names before Forge reads their contents, keeping counts, damage, enchantments, names and other NBT.
It also fixes the less obvious case where a chunk is first visited after the upgraded world has already been saved and restarted. The new CI fixture leaves a distant chest unopened across restarts, checks that its region stays unchanged, then visits it and checks another reload. Disabling stack recovery in a throwaway jar reproduced the item loss at that later visit.
Checks completed locally:
This prepares 2.6.1.112021. No registry entries or gameplay rules are changed. The README and changelog include the upgrade instructions and explain that other mods still need their own compatible versions. Agent notes, private worlds and generated test output are not included.