Repository navigation
Preserve translations in Windows builds - #506
Merged
SkyBlade1978 merged 1 commit intoOct 15, 2026
Merged
SkyBlade1978 merged 1 commit into
SkyBlade1978 merged 1 commit into
Conversation
SkyBlade1978
merged commit Oct 15, 2026
6265129
into
MinecraftModDevelopmentMods:master-1.19.4
4 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The final Windows/Linux artifact comparison caught translated characters being damaged by the Windows default text encoding.
The new audit rejects the old Windows jar. With the fix, the Windows main jar matches the tested Linux candidate byte for byte. The local build, unit tests, generated-data check and artifact audit pass.