Select multiple words/lines when double/triple clicking.#5127
Open
RobertP-McDowell wants to merge 3 commits into
Open
Select multiple words/lines when double/triple clicking.#5127RobertP-McDowell wants to merge 3 commits into
RobertP-McDowell wants to merge 3 commits into
Conversation
github-actions
Bot
added
needs triage
ossilator
suggested changes
Jun 14, 2026
ossilator
left a comment
ossilator
left a comment
Contributor
There was a problem hiding this comment.
the commit messages lack explanations/justifications of the changes.
also, judging by the commit message, the 2nd commit mixes two unrelated changes.
Author
|
I made each commit message clearer, and I thought changing the click time delay was an important enough change to warrant a third commit after all, so I split up the 2nd commit into two. |
mc-worker
reviewed
Jun 15, 2026
This is an improvement for double clicking in the editor, allowing the user to drag to select multiple words. Previously the user could only select one word at a time by double clicking. Signed-off-by: Robert P. McDowell <teatimewithrobert@gmail.com>
Like the last commit, improves triple clicking to allow the user to drag select multiple lines on double clicking in the editor. Signed-off-by: Robert P. McDowell <teatimewithrobert@gmail.com>
This is to compliment the last two commits. Before if the user dragged their mouse and tried to immediately click, they might unintentionally initiate a double click; with triple click being re-implemented it was a bigger issue, with accidental triple clicks. Signed-off-by: Robert P. McDowell <teatimewithrobert@gmail.com>
mc-worker
reviewed
Jun 19, 2026
| gboolean edit_load_menu_file (WDialog *h); | ||
| gboolean edit_close_cmd (WEdit *edit); | ||
| void edit_mark_cmd (WEdit *edit, gboolean unmark); | ||
| void edit_mark_words_cmd (WEdit *edit, gboolean unmark); |
Contributor
There was a problem hiding this comment.
This function is not implemented.
| void edit_mark_words_cmd (WEdit *edit, gboolean unmark); | ||
| void edit_mark_current_word_cmd (WEdit *edit); | ||
| void edit_mark_current_line_cmd (WEdit *edit); | ||
| void edit_get_current_word_extents (WEdit *edit, off_t *start, off_t *end); |
Contributor
There was a problem hiding this comment.
This function is defined and used in edit.c only. It should be static there.
| { | ||
| off_t word_start; | ||
| off_t word_end; | ||
| edit_get_current_word_extents (edit, &word_start, &word_end); |
Contributor
There was a problem hiding this comment.
Please add an empty line between variable declarations and code.
| edit_get_current_word_extents (WEdit *edit, off_t *start, off_t *end) | ||
| { | ||
| int test_left = edit_buffer_get_byte (&edit->buffer, edit->buffer.curs1 - 1); | ||
| int test_right = edit_buffer_get_byte (&edit->buffer, edit->buffer.curs1); |
Contributor
There was a problem hiding this comment.
These variables should be constants.
| return; | ||
| } | ||
|
|
||
| long pos; |
Contributor
There was a problem hiding this comment.
Please move this variable declaration to the begin of block.
| for (pos = edit->buffer.curs1; pos != 0; pos--) | ||
| { | ||
| int c1, c2; | ||
| int c2 = edit_buffer_get_byte (&edit->buffer, pos - 1); |
Contributor
There was a problem hiding this comment.
This variable should be constant,
| for (; pos < edit->buffer.size; pos++) | ||
| { | ||
| int c1, c2; | ||
| int c2 = edit_buffer_get_byte (&edit->buffer, pos + 1); |
Contributor
There was a problem hiding this comment.
This variable should be constant,
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Quality of life feature for mouse users. Many text editors have the ability to drag select words and lines, and mcedit already allows you to select one word at a time, this is just an improvement of what's already there!
Also updated how the delay between clicks works to start the timer on mouse down instead of up, this is a lot more common in text editors (you're very browser probably behaves this way); this change affects all other widgets that use double-click functionality.
Checklist
git commit --amend -smake indent && make check)Tested with both gpm and xterm-only mouse support, ncurses, and slang.