Update custom UDF location guidance for WinUI3 unpackaged#3845
Update custom UDF location guidance for WinUI3 unpackaged#3845elibroftw wants to merge 9 commits into
Conversation
|
Learn Build status updates of commit 55ad53e: ✅ Validation status: passed
For more details, please refer to the build report. |
|
|
||
| On this platform, use the default UDF location. | ||
| <!-- todo: review --> | ||
| On this platform, use the default UDF location if distributing as packaged. If distributing as unpackaged, in scenarios where the install directory is protected, you must specify a custom UDF location. |
There was a problem hiding this comment.
| --> | ||
| On this platform, use the default UDF location. | ||
| <!-- todo: review --> | ||
| On this platform, if distributing unpackaged to a protected install directory, you must specify a custom UDF location. |
There was a problem hiding this comment.
|
Learn Build status updates of commit 04dde44: ✅ Validation status: passed
For more details, please refer to the build report. |
| #### Example code | ||
|
|
||
| For example code, see the WinUI 3 `.cs` file, at [WebView2Samples repo > WebView2_WinUI3_Sample](https://github.com/MicrosoftEdge/WebView2Samples/tree/main/GettingStartedGuides/WinUI3_GettingStarted). | ||
| <!-- todo: review --> |
There was a problem hiding this comment.
review this code from Elijah
see custom code in Issue also
#2001
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
|
Learn Build status updates of commit 6e339bb: ✅ Validation status: passed
For more details, please refer to the build report. |
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
|
Learn Build status updates of commit f03a1d0: ✅ Validation status: passed
For more details, please refer to the build report. |
| // The default user data folder is next to the executable; however, the install dir (that is, /Program Files/) is protected. | ||
| var userDataFolder = Path.Combine( | ||
| Environment.GetFolderPath(Environment.SpecialFolder.LocalApplicationData), | ||
| "YOURAPPNAME", "WebView2"); // Decide whether you want to keep this dir after uninstall, or clean it up from the uninstaller. TODO: clarify "clean it up", ie delete the dir? |
There was a problem hiding this comment.
| "YOURAPPNAME", "WebView2"); // Decide whether you want to keep this dir after uninstall, or clean it up from the uninstaller. TODO: clarify "clean it up", ie delete the dir? | |
| "YOURAPPNAME", "WebView2"); // Decide whether you want to keep this dir after uninstall, or delete the dir by using the uninstaller. |
does "leave this" (in the orig commit) mean keep this dir?
does "clean it up" (in the orig commit) mean del the dir?
does "from the installer" (in the orig commit) mean "by using the installer?"
orig commit:
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
|
Learn Build status updates of commit 677df65: ✅ Validation status: passed
For more details, please refer to the build report. |
|
Learn Build status updates of commit 1c7448d: ✅ Validation status: passed
For more details, please refer to the build report. |
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
|
Learn Build status updates of commit b22e615: ✅ Validation status: passed
For more details, please refer to the build report. |
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
|
Learn Build status updates of commit 75fa423: ✅ Validation status: passed
For more details, please refer to the build report. |
|
|
||
| **Example code:** | ||
|
|
||
| For example code, see the WinUI 2 (UWP) `.cs` file, at [WebView2Samples repo > webview2_sample_uwp](https://github.com/MicrosoftEdge/WebView2Samples/tree/main/SampleApps/webview2_sample_uwp). |
There was a problem hiding this comment.
can we specify the file name?
|
|
||
| <!-- ```csharp --> | ||
| <!-- // ADO work item "[wv2] Update .NET (WPF/WinForms) sample to add code to retrieve UDF location" - then copy lines to here | ||
| <!-- todo: AB#? // ADO work item "[wv2] Update .NET (WPF/WinForms) sample to add code to retrieve UDF location" - then copy lines to here |
There was a problem hiding this comment.
AB#? [wv2] Update .NET (WPF/WinForms) sample to add code to retrieve UDF location
|
|
||
| <!-- ```csharp --> | ||
| <!-- // ADO work item "[wv2] Update ClickOnce sample to add code to retrieve UDF location" - then copy lines to here | ||
| <!-- todo: AB#? // ADO work item "[wv2] Update ClickOnce sample to add code to retrieve UDF location" - then copy lines to here |
There was a problem hiding this comment.
AB#? [wv2] Update ClickOnce sample to add code to retrieve UDF location
2 participants
Rendered article sections for review:
/webview2/concepts/user-data-folder.mdAB#62878749