Info compat fix#379
Merged
Merged
Conversation
Older versions of gen6 firmware do not support sn_ver_get subcmd = 1. Add a fallback for older firmware revisions subcmd = 0
lsgunth
approved these changes
May 20, 2026
Collaborator
lsgunth
left a comment
lsgunth
left a comment
There was a problem hiding this comment.
The change looks good.
Weird to have a version number change in what appears to be a bug fix PR.
BenReed161
force-pushed
the
info-compat-fix
branch
from
c338cf8 to
df20627
Compare
Collaborator
Author
|
Removed version commit in this PR, will add as a separate commit (not part of this PR). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The B012 firmware (0a050012) does not support subcmd=1 for MRPC 0x124 returns error 0x7d020. The newer B013 firmware (0a060013) does support it. Since both subcmds return the same reply struct, this is a firmware feature-level incompatibility. Add fallback if first subcmd=1 case fails