Skip to content

refactor: apply thermo-nuclear quality review fixes#118

Merged
Microck merged 1 commit into
mainfrom
quality/thermo-nuclear-review
Jun 3, 2026
Merged

refactor: apply thermo-nuclear quality review fixes#118
Microck merged 1 commit into
mainfrom
quality/thermo-nuclear-review

Conversation

@Microck

@Microck Microck commented Jun 3, 2026

Copy link
Copy Markdown
Owner

Summary

  • Fix search auth fallback state so session-preferred search does not store an API key in the session fallback slot.
  • Simplify CLI output-format dispatch by using existing Display implementations and removing template unwrap() branches.
  • Harden live Kagi account flows by retrying lens mutation lookups, validating lens names Kagi truncates, and making live Assistant tests use the account's available model catalog.
  • Refresh v0.9.0 Homebrew/Scoop packaging references and align release/npm workflow assertions with the current CLI/package behavior.
  • Update docs/examples for the live Assistant model slug.

Cleanup

  • Removed review-only .workflow/thermo-nuclear-code-quality-review artifacts.
  • Removed generated .dora files from the branch.
  • Kept the branch scoped to project source, docs, CI, and packaging files.

Verification

  • cargo fmt --check
  • cargo test -q --locked
  • cargo clippy --all-targets --all-features -- -D warnings
  • Earlier full verification included release build/package checks, serial ignored live tests, and live CLI smoke against the provided test account.

Clean up the current Kagi CLI branch after the strict maintainability pass: fix search fallback state, simplify output-format dispatch, harden live Kagi lens/account flows, and keep Assistant examples aligned with the live model catalog.

Refresh release/package metadata that drifted from v0.9.0 and keep the branch free of review-tool artifacts.
@Microck Microck enabled auto-merge June 3, 2026 15:05
@Microck Microck merged commit 8d6afd9 into main Jun 3, 2026
5 checks passed
@Microck Microck deleted the quality/thermo-nuclear-review branch June 3, 2026 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant