Conversation
A custom feed_tile_summary was rendered verbatim and overflowed the fixed-height (48px) summary slot of the news card. Clamp the rendered content to the slot with `line-clamp-2` + `overflow-hidden` instead of pre-truncating the markdown text. Closes #5189 Co-authored-by: aseckin <3686968+aseckin@users.noreply.github.com> Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🚀 Preview EnvironmentYour preview environment is ready!
Details
ℹ️ Preview Environment InfoIsolation:
Limitations:
Cleanup:
|
|
@claude increase to line-clamp-3 |
|
@claude just for tablet and desktop screens, keep 2 for mobile |
|
Claude finished @aseckin's task in 1m 3s —— View job Increased summary clamp to 3 lines
Pushed 257062d to this branch. Changes in
The card's I did not run lint or type checks (no Bash allowed), but the change is purely to class strings and a numeric literal. |
Bump the summary slot from 48px to 72px so a third line fits, and raise the fallback getMarkdownSummary height to match. Co-authored-by: aseckin <3686968+aseckin@users.noreply.github.com> Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
Claude finished @aseckin's task in 52s —— View job Summary clamp is now responsive
Pushed in e3e15bf. Changes in
Not verified: I couldn't run prettier/eslint on the file (Bash with shell operators is blocked in this run), so please rely on CI for lint. |
Co-authored-by: aseckin <3686968+aseckin@users.noreply.github.com> Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
A custom
feed_tile_summarywas rendered verbatim and overflowed the fixed-height (48px) summary slot of the news card. The rendered content is now clamped to the slot withline-clamp-2(ellipsis) plusoverflow-hiddenon the slot, instead of pre-truncating the markdown text.getMarkdownSummaryremains only as the fallback for notebooks without a custom summary.Closes #5189
Generated with Claude Code