chore: drop Core leftovers from the root package - #176
Merged
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
The root package no longer calls tsc, so depcheck cannot see that TypeScript is still required for type-aware linting.
The Node 24 types bump left a leftover 22.7.5 resolution that fails yarn dedupe --check.
Restore the original publishing steps, fix the @metamaskbot comment typo, and point independent contributors at local builds instead of the missing Yarn commands.
NODE_LTS_VERSION 24 no longer flags those builtins, so leftover suppressions fail lint:eslint.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
The root
package.jsonstill carried MetaMask Core-era scripts and config that do not apply to this Snap monorepo.lint:eslintwipedpackages/*/distand raised the Node heap to 6GB before running ESLint. Dist is already ignored, and this repo is much smaller than Core, so that is justyarn eslint.@types/nodewas still on 16 while we treat Node 24 as current LTS, so types (andNODE_LTS_VERSIONin ESLint) now match 24. Packageenginesstay>=20to match what we want to support and our CI's (which run a matrix of versions).build:types,setup) andfiles: []are gone. Yarn constraints unset rootfilesso it cannot come back.simple-git-hookspre-push config is removed (the dependency remains).@metamaskbot publish-preview), and independent contributors are pointed at local builds instead of the missing Yarn commands. The workflowdocs-urlpoints at this repo instead of Core.firt-party→first-party.No package APIs changed.
References
N/A
Checklist