fix(tron-wallet-snap): distinguish inactive accounts from HTTP failures on fetchAssetsAndBalancesForAccount - #151
Merged
ulissesferreira merged 1 commit intoAug 18, 2026
Conversation
ulissesferreira
added a commit
that referenced
this pull request
Aug 14, 2026
ulissesferreira
added a commit
that referenced
this pull request
Aug 14, 2026
ulissesferreira
force-pushed
the
fix/core-assets-adapter-check-rejection-reason
branch
from
August 14, 2026 14:19
ffba7d0 to
8cc6f10
Compare
ulissesferreira
added a commit
that referenced
this pull request
Aug 14, 2026
ulissesferreira
force-pushed
the
fix/core-assets-adapter-check-rejection-reason
branch
from
August 14, 2026 14:21
8cc6f10 to
68dea61
Compare
ulissesferreira
force-pushed
the
fix/core-assets-adapter-check-rejection-reason
branch
from
August 14, 2026 14:28
68dea61 to
bc18ebd
Compare
fetchAssetsAndBalancesForAccount
…es on `fetchAssetsAndBalancesForAccount`
ulissesferreira
force-pushed
the
fix/core-assets-adapter-check-rejection-reason
branch
from
August 14, 2026 14:33
bc18ebd to
61a6817
Compare
stanleyyconsensys
approved these changes
Aug 17, 2026
stanleyyconsensys
left a comment
Contributor
There was a problem hiding this comment.
thx for the work, Looks great to me
i assume you already have some place to catch and trace the error
just question, since u dont throw error when acc is not found,
can we assume addressResourcesRequest and addressStakingRewardsRequest will not throw error if account not found?
Contributor
Author
Yes we can, they basically just return empty |
ulissesferreira
deleted the
fix/core-assets-adapter-check-rejection-reason
branch
August 18, 2026 08:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Promise.allSettledrejectionreasoninCoreAssetsAdapter.fetchAssetsAndBalancesForAccount.TrongridAccountNotFoundErroras an inactive account; rethrow HTTP and other unexpected failures from account info, resources, and staking rewards instead of reporting zero balances.Test plan
TrongridAccountNotFoundError) still return zero snap-owned assetsTrongridHttpErrorfrom account info fails the fetch instead of looking like an inactive accountgetAccountResources/getRewardalso fail the fetchyarn workspace @metamask/tron-wallet-snap run test(orcheck-tron)