Skip to content

fix: stable sync secret#113

Merged
Qbandev merged 2 commits into
mainfrom
fix-stable-sync-secret
Aug 28, 2025
Merged

fix: stable sync secret#113
Qbandev merged 2 commits into
mainfrom
fix-stable-sync-secret

Conversation

@Qbandev

@Qbandev Qbandev commented Aug 28, 2025

Copy link
Copy Markdown
Contributor

Fix: Add missing secret declaration to stable-sync workflow

What is the current state and why does it need to change?

The stable-sync.yml reusable workflow is failing validation when called from other workflows (e.g., metamask-extension's stable-branch-sync.yml)
The workflow uses a GitHub token internally for creating pull requests but doesn't declare that it accepts this secret when called via workflow_call, causing validation failures in caller workflows.

What is the solution?

This PR adds the missing secrets section to the workflow_call trigger, explicitly declaring that the workflow accepts a github-token secret. The changes include:

  • Added secrets.github-token declaration to the workflow_call trigger (required: true)
  • Updated the internal reference from ${{ secrets.GITHUB_TOKEN }} to ${{ secrets.github-token }} for consistency
  • Made the secret required since PR creation will fail without it

Related Issues

  • Fixes workflow validation errors in repositories using this shared workflow
  • Enables proper secret passing from caller workflows like metamask-extension/.github/workflows/stable-branch-sync.yml

@Qbandev Qbandev requested a review from Copilot August 28, 2025 09:16

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a validation error in the stable-sync.yml reusable workflow by properly declaring the GitHub token secret that the workflow requires for creating pull requests.

  • Adds missing secrets declaration to the workflow_call trigger
  • Updates internal token reference to use the declared secret parameter
  • Makes the secret required since PR creation functionality depends on it

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread .github/workflows/stable-sync.yml
@Qbandev Qbandev merged commit 486f5d1 into main Aug 28, 2025
18 checks passed
@Qbandev Qbandev deleted the fix-stable-sync-secret branch August 28, 2025 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants