fix: stable sync secret#113
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a validation error in the stable-sync.yml reusable workflow by properly declaring the GitHub token secret that the workflow requires for creating pull requests.
- Adds missing
secretsdeclaration to theworkflow_calltrigger - Updates internal token reference to use the declared secret parameter
- Makes the secret required since PR creation functionality depends on it
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
jluque0101
approved these changes
Aug 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Add missing secret declaration to stable-sync workflow
What is the current state and why does it need to change?
The
stable-sync.ymlreusable workflow is failing validation when called from other workflows (e.g.,metamask-extension'sstable-branch-sync.yml)The workflow uses a GitHub token internally for creating pull requests but doesn't declare that it accepts this secret when called via
workflow_call, causing validation failures in caller workflows.What is the solution?
This PR adds the missing
secretssection to theworkflow_calltrigger, explicitly declaring that the workflow accepts agithub-tokensecret. The changes include:secrets.github-tokendeclaration to theworkflow_calltrigger (required: true)${{ secrets.GITHUB_TOKEN }}to${{ secrets.github-token }}for consistencyRelated Issues
metamask-extension/.github/workflows/stable-branch-sync.yml