feat(wallet-cli): add the mm wallet send command

[sirtimid]

Explanation

Adds the user-facing mm wallet send command that sends a transaction end-to-end through the daemon-hosted TransactionController, closing #9513. This is the CLI surface on top of the daemon's transaction capability (#9512 / #9612): it collects transaction parameters, dispatches them to the daemon, waits for the broadcast, and reports the resulting transaction hash.

Send a transaction. --value is in ether; select the network with --network-client-id or --chain-id; the sender defaults to the selected account. The command previews the resolved plan and asks for confirmation before broadcasting, then prints the transaction hash:

Because the daemon auto-approves the confirmation prompt — or your explicit --yes — is the only boundary before funds move; use --dry-run first if unsure. Gas is estimated automatically unless overridden with --gas / --max-fee-per-gas / --max-priority-fee-per-gas / --gas-price (each a 0x-prefixed hex quantity).

Dedicated sendTransaction RPC handler

TransactionController:addTransaction returns a Result shaped like { transactionMeta, result }, where result is a Promise<hash> that resolves once the transaction is signed and broadcast. That promise is not JSON-serializable, so it cannot travel back over the daemon's generic call dispatch. The daemon therefore exposes a dedicated sendTransaction handler (src/daemon/send-transaction.ts) that, server-side:

1. resolves the network client — from networkClientId, or from chainId via NetworkController:findNetworkClientIdByChainId;
2. resolves the sender — the provided --from, or the selected account;
3. calls addTransaction(txParams, { networkClientId, origin: 'metamask', isInternal: true }) (internal, so it skips origin/permitted-account validation and is auto-approved by the headless daemon);
4. awaits the broadcast and re-reads the live record so the returned status reflects the post-broadcast state (submitted), not the unapproved creation snapshot;
5. returns a serializable { transactionHash, transactionId, status }.

Params are validated with superstruct at the daemon boundary (exactly one of networkClientId / chainId; 0x address and hex quantities).

The mm wallet send command

A thin client over that handler (src/commands/wallet/send.ts):

➜  wallet-cli: yarn mm wallet send --help
  Send a transaction through the daemon-hosted TransactionController. Estimates gas automatically
  unless overridden, signs, broadcasts, and prints the resulting transaction hash. The daemon
  auto-approves, so the confirmation boundary is this command.

USAGE
  $ mm wallet send --to <value> [--value <value>] [--from <value>] [--data <value>]
    [--network-client-id <value>] [--chain-id <value>] [--gas <value>] [--max-fee-per-gas <value>]
    [--max-priority-fee-per-gas <value>] [--gas-price <value>] [--dry-run] [-y] [-t <value>]

FLAGS
  -t, --timeout=<value>                   Response timeout in milliseconds
  -y, --yes                               Skip the confirmation prompt and broadcast immediately.
      --chain-id=<value>                  Chain ID (0x-prefixed hex) to resolve to a network client.
                                          Provide this or --network-client-id, not both.
      --data=<value>                      Calldata as a 0x-prefixed hex string (for contract calls)
      --dry-run                           Resolve the network client and sender and validate params,
                                          but do not broadcast.
      --from=<value>                      Sender address (0x-prefixed). Defaults to the selected
                                          account.
      --gas=<value>                       Gas limit override, as a 0x-prefixed hex quantity
      --gas-price=<value>                 Legacy gasPrice override, as a 0x-prefixed hex wei quantity
      --max-fee-per-gas=<value>           maxFeePerGas override, as a 0x-prefixed hex wei quantity
      --max-priority-fee-per-gas=<value>  maxPriorityFeePerGas override, as a 0x-prefixed hex wei
                                          quantity
      --network-client-id=<value>         Network client to send on. Provide this or --chain-id, not
                                          both.
      --to=<value>                        (required) Recipient address (0x-prefixed)
      --value=<value>                     [default: 0] Amount to send, in ether (e.g. 0.01). Defaults
                                          to 0.

EXAMPLES
  $ mm wallet send --to 0xRecipient --value 0.01 --chain-id 0x1

  $ mm wallet send --to 0xRecipient --value 0.01 --network-client-id mainnet --yes

  $ mm wallet send --to 0xContract --data 0xabcdef --value 0 --chain-id 0x1 --dry-run

Testing

• Unit tests for the handler (network/sender resolution, internal submit, dry-run, broadcast + live status, param validation) and the command (arg parsing, preview/confirm/abort, --yes, --dry-run, error surfaces); 100% coverage maintained.
• Real-chain e2e (tests/wallet-send.e2e.test.ts): boots a local anvil node, adds it as a custom network, and drives the built mm CLI to sign, broadcast, and mine a real transaction (asserts receipt status: 0x1 and a recipient balance increase). It is skip-if-absent; CI installs anvil for it only when packages/wallet-cli/ changed. See packages/wallet-cli/tests/README.md.
• build, package test, test:e2e, yarn lint, changelog:validate pass.

References

• Closes wallet-cli: add the mm send-transaction command #9513
• Builds on wallet-cli: make the daemon transaction-capable — consume GasFeeController + headless auto-approval #9512 / feat!: wire NetworkEnablementController to ConfigRegistryController #9611 (daemon transaction-capable) and feat(wallet-cli): wire the TransactionController slot in the daemon wallet #9509 (the TransactionController slot); the mutating-RPC safety prerequisite wallet-cli: make sendCommand retry idempotency-safe before mutating RPC ships #9511 landed in fix(wallet-cli): retry sendCommand only on ECONNREFUSED #9608.
• packages/wallet-cli/src/daemon/send-transaction.ts, src/commands/wallet/send.ts, tests/wallet-send.e2e.test.ts.

Note

Stacked on sirtimid/wallet-cli-daemon-transaction-capable (#9612); this PR is based on that branch so the diff is scoped. Once #9612 merges, this will be rebased onto main and retargeted.

Checklist

• Tests cover the handler and command (unit) plus a real-chain broadcast (e2e); 100% coverage maintained.
• build, test, test:e2e, yarn lint:fix, yarn lint, changelog:validate pass.
• Confirmation prompt (--yes to skip) and --dry-run gate a real, irreversible send.

🤖 Generated with Claude Code

---

Note

High Risk
Introduces an irreversible fund-moving send path; the headless daemon still auto-approves, so the CLI confirmation (or --yes) is the main per-tx gate—timeouts and duplicate-send guidance are safety-critical.

Overview
Adds mm wallet send, a CLI path to sign and broadcast through the daemon’s TransactionController. Ether --value is converted to wei; the network is chosen with --network-client-id or --chain-id; interactive runs dry-run preview → confirmSend → broadcast, with --yes, --dry-run, optional gas overrides, and a longer default timeout on broadcast (with guidance if the client times out while a send may still be in flight).

Because addTransaction’s result promise is not JSON-serializable, the daemon gains a dedicated sendTransaction RPC (runSendTransaction) that resolves network/sender, supports dryRun, submits as internal/auto-approved, awaits the hash server-side, and returns { transactionHash, transactionId, status }.

CI/docs/tooling: wallet-cli e2e installs anvil via @metamask/foundryup, sets MM_E2E_REQUIRE_ANVIL in CI, adds wallet-send.e2e.test.ts (local anvil, real broadcast), and ignores .metamask/ / knip anvil binary.

^{Reviewed by Cursor Bugbot for commit 208b060. Bugbot is set up for automated code reviews on this repo. Configure here.}

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit b41b710. Configure here.}