feat(config-registry-controller)!: index configs by caip chain id#9606
Merged
Conversation
mikesposito
commented
Jul 22, 2026
Co-authored-by: Michele Esposito <34438276+mikesposito@users.noreply.github.com>
mikesposito
commented
Jul 22, 2026
mikesposito
marked this pull request as ready for review
July 22, 2026 15:39
mikesposito
temporarily deployed
to
default-branch
July 22, 2026 15:39 — with
GitHub Actions
Inactive
gabrieledm
approved these changes
Jul 23, 2026
Battambang
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
The
ConfigRegistryControllerState.configs.networkstype is being narrowed down toRecord<CaipChainId, RegistryNetworkConfig>instead ofRecord<string, RegistryNetworkConfig>References
Checklist
Note
Medium Risk
Breaking TypeScript types for
configs.networksand lookup parameters require consumer updates; runtime behavior is mostly unchanged aside from stricter chain ID validation on API responses.Overview
BREAKING: Network configs in controller state are now keyed and typed as
CaipChainIdinstead of arbitrary strings.ConfigRegistryControllerState.configs.networksbecomesRecord<CaipChainId, RegistryNetworkConfig>, andgetNetworkConfigByCaip2ChainIdtakes aCaipChainIdargument.Registry API parsing now validates each chain’s
chainIdwithCaipChainIdStructfrom@metamask/utils, so only CAIP-2-shaped IDs (e.g.eip155:1) are accepted at the type/schema layer. The changelog documents the breaking state shape change and ties it to the existing lookup API.Reviewed by Cursor Bugbot for commit 8c8a1f8. Bugbot is set up for automated code reviews on this repo. Configure here.