Skip to content

fix(assets-controller): increase stale and gc time for accounts api request #9591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kriys94 merged 2 commits into from
Jul 23, 2026
+7 −3
Merged

fix(assets-controller): increase stale and gc time for accounts api request #9591

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e47633
fix(assets-controller): increase stale and g time for accounts api re…
Kriys94 Jul 22, 2026
1659296
update changelog
Kriys94 Jul 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/assets-controller/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Fixed

- `AccountsApiDataSource` `forceUpdate` balance fetches now use `staleTime`/`gcTime` of `100`ms (previously `0`/`0`) so bursts of near-simultaneous forced refreshes are de-duplicated by TanStack Query into a single Accounts API request instead of one request per trigger ([#9591](https://github.com/MetaMask/core/pull/9591))

## [11.1.1]

### Changed
Expand Down
4 changes: 2 additions & 2 deletions packages/assets-controller/src/data-sources/AccountsApiDataSource.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,15 +377,15 @@ describe('AccountsApiDataSource', () => {
controller.destroy();
});

it('fetch bypasses TanStack cache when forceUpdate is true', async () => {
it('uses a short-lived TanStack cache window when forceUpdate is true', async () => {
const { controller, apiClient } = await setupController();

await controller.fetch(createDataRequest({ forceUpdate: true }));

expect(apiClient.accounts.fetchV5MultiAccountBalances).toHaveBeenCalledWith(
[`eip155:1:${MOCK_ADDRESS}`],
undefined,
{ staleTime: 0, gcTime: 0 },
{ staleTime: 100, gcTime: 100 },
);

controller.destroy();
Expand Down
2 changes: 1 addition & 1 deletion packages/assets-controller/src/data-sources/AccountsApiDataSource.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,7 +376,7 @@ export class AccountsApiDataSource extends AbstractDataSource<
}

const fetchOptions = request.forceUpdate
? { staleTime: 0, gcTime: 0 }
? { staleTime: 100, gcTime: 100 }
: undefined;

// Feature-flagged: v6 endpoint with a fallback to legacy v5. The flag is
Expand Down