chore: init activeAssetCtxPrice price resolution#9160
Draft
gambinish wants to merge 1 commit into
Draft
Conversation
Member
Author
|
@metamaskbot publish-previews |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Prefer
activeAssetCtxprice on detail/ticket screens to absorb 5sallMidscadenceHyperliquid is throttling the
allMidsWebSocket stream to push every ~5 seconds. For list/overview screens this is fine, but on a focused single-symbol view (trade detail, order ticket) the displayed price would noticeably lag at that interval.This PR fixes that by making
subscribeToPricescalls withincludeMarketData: trueuse the per-symbolactiveAssetCtxstream as the source of truth for the displayed price. That stream already ticks at a faster cadence and was already established for market-data-enabled subscriptions — this change just wires itsmidPx/markPxthrough toPriceUpdate.priceinstead of waiting for the nextallMidssnapshot.A 10-second staleness gate ensures that if the fast stream goes quiet,
allMidstakes back over automatically.What changed:
#marketDataCachenow stores the lastactiveAssetCtxprice and its timestamp per symbol#createPriceUpdateprefers the fresh fast-stream price over the passed-inallMidsprice (with TTL fallback)The
activeAssetCtxhandler drives price updates directly from the incomingmidPx/markPxrather than replaying the last cachedallMidsvalueA comment on
#ensureGlobalAllMidsSubscriptiondocuments the 5s cadence and the mitigation strategyWhat didn't change:
List/overview screens (
includeMarketData: false) are completely unaffected — they still run onallMidsonlyNo new WebSocket subscriptions are created;
activeAssetCtxwas already reference-counted underincludeMarketDataReferences
Checklist