fix(transaction-pay-controller): sync transaction metadata when fiat payment has no payment token#9158
Open
OGPoyraz wants to merge 1 commit into
Open
fix(transaction-pay-controller): sync transaction metadata when fiat payment has no payment token#9158OGPoyraz wants to merge 1 commit into
OGPoyraz wants to merge 1 commit into
Conversation
…payment has no payment token
OGPoyraz
force-pushed
the
fix/transaction-pay-fiat-sync
branch
from
4072435 to
39099ee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a fiat payment method is selected,
paymentTokenis not present. The previous guard insyncTransactionused||which required both to be present, blocking the fiat-only path entirely.Changed the guard from
&&to||so that having eitherpaymentTokenorselectedFiatPaymentis sufficient to proceed.Changes
syncTransaction: guard changed from!paymentToken || !selectedFiatPayment→!paymentToken && !selectedFiatPaymenttx.metamaskPaywhen fiat payment is set but nopaymentToken