feat(ramps-controller): export Transak API error helpers and codes#9135
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Author
|
Coordination
|
Open
2 tasks
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
Link the Transak API error helper changelog entry to #9135 and apply lint:misc import-order formatting for the new ramps-controller files. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
Export only getTransakApiMessage and isTransakPhoneRegisteredError for mobile consumers. Drop shared error code constants and generic helpers from the public API and leave TransakService order-retry logic unchanged. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
Author
|
@metamaskbot publish-preview Re-publishing after |
Keep getTransakApiMessage and isTransakPhoneRegisteredError as the only public helpers while sharing ORDER_EXISTS and PHONE_ALREADY_REGISTERED in transakErrorCodes.ts for TransakService and error utils. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Author
|
@metamaskbot publish-preview After |
Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Author
|
@metamaskbot publish-preview After |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
matteyu
approved these changes
Jun 16, 2026
matteyusys
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Unified Buy v2 (and other
@metamask/ramps-controllerconsumers) need to detect specific Transak API failures fromTransakApiError— for example error code2020when a phone number is already registered to a different email. Today, mobile duplicated string literals and ad-hocinstanceof/ Axios-shaped parsing because ramps-controller only exportedTransakApiErroritself, not reusable helpers or known codes.This PR adds shared Transak error codes and small type guards/helpers so consumers can branch on
errorCodeand readapiMessageconsistently:TRANSAK_ERROR_CODES(ORDER_EXISTS: '4005',PHONE_ALREADY_REGISTERED: '2020') andTransakErrorCodeisTransakApiError,getTransakErrorCode,getTransakApiMessage,isTransakErrorCode,isTransakPhoneRegisteredErrorTransakServicenow usesTRANSAK_ERROR_CODES.ORDER_EXISTSinstead of a private'4005'constant so order-exists retry logic and public exports stay aligned.No breaking changes. Changelog updated under
@metamask/ramps-controllerUnreleased.References
Checklist