Skip to content

feat(wallet): wire TransactionController into default initialization#8975

Open
matthewwalsh0 wants to merge 1 commit into
mainfrom
feat/wallet-wire-transaction-controller
Open

feat(wallet): wire TransactionController into default initialization#8975
matthewwalsh0 wants to merge 1 commit into
mainfrom
feat/wallet-wire-transaction-controller

Conversation

@matthewwalsh0

@matthewwalsh0 matthewwalsh0 commented Jun 2, 2026

Copy link
Copy Markdown
Member

Explanation

Adds packages/wallet/src/initialization/instances/transaction-controller/ following the same pattern established by the approval-controller/ directory in #8953.

The directory contains:

  • transaction-controller.ts — the InitializationConfiguration that wires TransactionController into the default wallet initialization, delegating messenger actions from the root and creating a typed child messenger for the controller
  • types.tsTransactionControllerInitMessenger, TransactionControllerInitMessengerActions, TransactionControllerInitMessengerEvents, and TransactionControllerInstanceOptions (a subset of TransactionControllerOptions that exposes only the genuinely platform-specific options; shared defaults are hardcoded in the config)

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

@matthewwalsh0 matthewwalsh0 force-pushed the feat/wallet-wire-transaction-controller branch 4 times, most recently from c3042bb to 9677e31 Compare June 2, 2026 21:23
@matthewwalsh0 matthewwalsh0 force-pushed the feat/wallet-wire-transaction-controller branch from 58d79cc to 0069b11 Compare June 3, 2026 09:02
@matthewwalsh0 matthewwalsh0 force-pushed the feat/wallet-wire-transaction-controller branch from 4bf9b25 to 2aac690 Compare June 3, 2026 12:36
@matthewwalsh0 matthewwalsh0 changed the base branch from main to chore/remove-deprecated-tx-options June 3, 2026 12:36
@matthewwalsh0 matthewwalsh0 force-pushed the chore/remove-deprecated-tx-options branch from de6504d to bfc8a1a Compare June 4, 2026 16:24
Base automatically changed from chore/remove-deprecated-tx-options to main June 5, 2026 08:33
@matthewwalsh0 matthewwalsh0 force-pushed the feat/wallet-wire-transaction-controller branch 4 times, most recently from b0847c9 to 26ad858 Compare June 16, 2026 20:42
@matthewwalsh0 matthewwalsh0 force-pushed the feat/wallet-wire-transaction-controller branch from 26ad858 to 5c48b39 Compare June 16, 2026 20:45
@matthewwalsh0 matthewwalsh0 marked this pull request as ready for review June 16, 2026 20:58
@matthewwalsh0 matthewwalsh0 requested a review from a team as a code owner June 16, 2026 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant