feat(account-tree-controller): re-introduce lastSelected metadata#8261
Open
feat(account-tree-controller): re-introduce lastSelected metadata#8261
lastSelected metadata#8261Conversation
ccharly
force-pushed
the
cc/fix/group-last-selected-metadata
branch
2 times, most recently
from
aa318fb to
ba6d99f
Compare
ccharly
force-pushed
the
cc/fix/group-last-selected-metadata
branch
from
ba6d99f to
cc3d9fe
Compare
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
| } | ||
| } | ||
| } | ||
| return candidate?.id ?? ''; |
There was a problem hiding this comment.
Persisted lastSelected ignored during init fallback path
Low Severity
In init(), #getDefaultSelectedAccountGroup(wallets) receives the original wallets object rather than state.accountTree.wallets (the Immer draft). Since #applyAccountGroupMetadata writes persisted lastSelected values through the draft (copy-on-write), these updates are not reflected in the original wallets reference. If #getDefaultAccountGroupId is reached as a fallback, all groups appear to have lastSelected: 0, making the new lastSelected-based ranking ineffective during init and falling back to the EVM tiebreaker instead.
Additional Locations (1)
| state.accountTree.wallets[walletId].groups[ | ||
| groupId | ||
| ].metadata.lastSelected = now; | ||
| } |
There was a problem hiding this comment.
Duplicated lastSelected update logic across two methods
Low Severity
The block that guards accountGroupsMetadata[groupId], captures Date.now(), and writes lastSelected to both persisted metadata and the tree is copy-pasted identically in setSelectedAccountGroup and #handleSelectedAccountChange. Extracting this into a shared private helper would reduce the risk of future inconsistent updates between the two call sites.
Additional Locations (1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Some logic still relies on this metadata on accounts. Since we want to deprecate the
AccountsControllerat some point, we need to reintroduce this concept, but at the group level this time.References
N/A
Checklist
Note
Medium Risk
Medium risk because it changes how the controller persists/derives the default
selectedAccountGroup, which can affect account selection after removals or restarts if timestamps or metadata restoration behave unexpectedly.Overview
Adds a
lastSelectedtimestamp to account-group metadata, persisting it inaccountGroupsMetadata(local-only) and restoring it during tree initialization.Updates selection flows (
setSelectedAccountGroupandAccountsController:selectedAccountChange) to stampDate.now()into both persisted metadata and the in-tree group node, and changes default-group fallback logic to prefer the most recently selected non-empty group (with an EVM-account tiebreaker). Tests and rule-generated defaults are updated to includelastSelected: 0and to cover the new fallback/restore behavior.Written by Cursor Bugbot for commit cc3d9fe. This will update automatically on new commits. Configure here.