chore: suppress existing type errors so lint:tsc can run in CI - #10251
Draft
cryptodev-2s wants to merge 1 commit into
Draft
cryptodev-2s wants to merge 1 commit into
cryptodev-2s wants to merge 1 commit into
Conversation
Adds tsc-suppressions.json, which records how many type errors of each code every file currently produces, in the same shape as eslint-suppressions.json. yarn lint:tsc:check typechecks the repo and fails when a file produces an error the suppressions do not cover, or when a suppression no longer covers anything. yarn lint:tsc:suppress regenerates the file. Also gives the package lint configs a rootDir so that declarations for files outside a package, such as tests/helpers.ts, are emitted into the lint cache rather than into the repo.
cryptodev-2s
force-pushed
the
tsc-suppressions
branch
from
September 15, 2026 15:50
c28d40a to
6a7a76d
Compare
cryptodev-2s
changed the title
Contributor
Author
|
@mcmire I am still reviewing this however does the idea sounds to you ? |
Collaborator
|
@cryptodev-2s Yeah if you can get this working this would be great! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
lint:tsctypechecks every package, but the repo currently has 1,591 type errors, nearly all of them in test files. That makes it impossible to enforce typechecking in CI without fixing everything first.This adds
tsc-suppressions.json, which records how many errors of each code every file currently produces, in the same shape aseslint-suppressions.json.yarn lint:tsc:checktypechecks the repo and fails when a file produces an error the suppressions don't cover, or when a suppression no longer covers anything.yarn lint:tsc:suppressregenerates the file.Existing errors stay parked so they can be worked through package by package, while packages that are already clean can't regress. A cold run takes about 12 seconds, so the check is wired back into CI and into
yarn lint.Error messages are deliberately left out of the suppression key. Their wording changes between TypeScript releases, which would invalidate the whole file at once.
Checklist