Skip to content

chore: make Assets the sole codeowner of core-backend #10250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kriys94 merged 1 commit into from
Sep 16, 2026
+8 −8
Merged

chore: make Assets the sole codeowner of core-backend #10250

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
/packages/assets-controllers @MetaMask/metamask-assets
/packages/network-enablement-controller @MetaMask/metamask-assets
/packages/assets-controller @MetaMask/metamask-assets
/packages/core-backend @MetaMask/metamask-assets

## Confirmations Team
/packages/address-book-controller @MetaMask/confirmations
Expand Down Expand Up @@ -135,7 +136,6 @@
## Joint team ownership
/packages/announcement-controller @MetaMask/core-extension-ux @MetaMask/mobile-core-ux
/packages/client-utils @MetaMask/core-extension-ux @MetaMask/mobile-core-ux
/packages/core-backend @MetaMask/core-platform @MetaMask/metamask-assets
/packages/eth-json-rpc-middleware/src/methods @MetaMask/confirmations @MetaMask/core-platform
/packages/eth-json-rpc-middleware/src/wallet.* @MetaMask/confirmations @MetaMask/core-platform
/packages/foundryup @MetaMask/mobile-platform @MetaMask/extension-platform
Expand Down Expand Up @@ -389,10 +389,10 @@
/packages/subscription-controller/CHANGELOG.md @MetaMask/web3auth @MetaMask/core-platform
/packages/subscription-controller/tsconfig.* @MetaMask/web3auth @MetaMask/core-platform
/packages/subscription-controller/typedoc.json @MetaMask/web3auth @MetaMask/core-platform
/packages/core-backend/package.json @MetaMask/core-platform @MetaMask/metamask-assets
/packages/core-backend/CHANGELOG.md @MetaMask/core-platform @MetaMask/metamask-assets
/packages/core-backend/tsconfig.* @MetaMask/core-platform @MetaMask/metamask-assets
/packages/core-backend/typedoc.json @MetaMask/core-platform @MetaMask/metamask-assets
/packages/core-backend/package.json @MetaMask/metamask-assets @MetaMask/core-platform
/packages/core-backend/CHANGELOG.md @MetaMask/metamask-assets @MetaMask/core-platform
/packages/core-backend/tsconfig.* @MetaMask/metamask-assets @MetaMask/core-platform
/packages/core-backend/typedoc.json @MetaMask/metamask-assets @MetaMask/core-platform
/packages/claims-controller/package.json @MetaMask/web3auth @MetaMask/core-platform
/packages/claims-controller/CHANGELOG.md @MetaMask/web3auth @MetaMask/core-platform
/packages/claims-controller/tsconfig.* @MetaMask/web3auth @MetaMask/core-platform
Expand Down
4 changes: 2 additions & 2 deletions codeowners.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ const PACKAGES: Record<string, PackageInfo> = {
teams: ['@MetaMask/core-platform'],
},
'core-backend': {
teams: ['@MetaMask/core-platform', '@MetaMask/metamask-assets'],
teams: ['@MetaMask/metamask-assets'],
},
cryptography: {
teams: ['@MetaMask/core-platform'],
Expand Down Expand Up @@ -451,6 +451,7 @@ function buildTeamSections(): CodeownersSection[] {
buildRuleForPackage('assets-controllers'),
buildRuleForPackage('network-enablement-controller'),
buildRuleForPackage('assets-controller'),
buildRuleForPackage('core-backend'),
],
},
{
Expand Down Expand Up @@ -606,7 +607,6 @@ function buildJointTeamOwnershipSection(): CodeownersSection {
rules: [
buildRuleForPackage('announcement-controller'),
buildRuleForPackage('client-utils'),
buildRuleForPackage('core-backend'),
{
pattern: '/packages/eth-json-rpc-middleware/src/methods',
owners: ['@MetaMask/confirmations', '@MetaMask/core-platform'],
Expand Down
2 changes: 1 addition & 1 deletion teams.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@
"metamask/claims-controller": "team-shield",
"metamask/announcement-controller": "team-core-extension-ux,team-mobile-ux",
"metamask/client-utils": "team-core-extension-ux,team-mobile-ux",
"metamask/core-backend": "team-core-platform,team-assets",
"metamask/core-backend": "team-assets",
"metamask/eth-block-tracker": "team-core-platform",
"metamask/eth-json-rpc-middleware": "team-core-platform,team-confirmations",
"metamask/eth-json-rpc-provider": "team-core-platform",
Expand Down