chore(utils): resolve in operator lint suppressions - #10248
Draft
cryptodev-2s wants to merge 1 commit into
Draft
cryptodev-2s wants to merge 1 commit into
cryptodev-2s wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Clears the 6
no-restricted-syntaxsuppressions the@metamask/utilsmigration left ineslint-suppressions.json. All 6 are theinoperator.hashing.ts(3): the'crypto' in globalThisguard was redundant with thetypeof globalThis.crypto === 'object'check on the next line, so it is gone. Identical behaviour.errors.ts(3): these stay, now with inline disables explaining why.hasPropertyis own property only, and prototype lookup is the point here:Same for
codedefined on an error subclass prototype. Swapping would silently changeisErrorWithMessage,isErrorWithCodeandisErrorWithStack, which are public exports.No behaviour change, so no changelog entry.
References
Follows #10185
Checklist