Skip to content

chore(utils): resolve node builtins lint suppressions in hashing tests - #10247

Draft
cryptodev-2s wants to merge 1 commit into
mainfrom
chore/utils-fix-node-builtins-suppressions
Draft

cryptodev-2s wants to merge 1 commit into
mainfrom
chore/utils-fix-node-builtins-suppressions

Conversation

@cryptodev-2s

Copy link
Copy Markdown
Contributor

Explanation

Clears the 9 n/no-unsupported-features/node-builtins suppressions the @metamask/utils migration left in eslint-suppressions.json.

All 9 are globalThis.crypto in hashing.test.ts. Test files extend the nodejs ESLint config and pin settings.node.version to ^22, where the rule treats globalThis.crypto as experimental. hashing.ts is not flagged because non test sources do not extend that config.

The tests stub the exact global that hashing.ts reads, so there is nothing to rewrite. Replaced the bulk suppression with one file level disable that says why.

Test only, so no changelog entry.

References

Follows #10185

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant