Skip to content

chore: correct stale exports comment - #10244

Open
cryptodev-2s wants to merge 1 commit into
mainfrom
chore/fix-stale-exports-comment
Open

cryptodev-2s wants to merge 1 commit into
mainfrom
chore/fix-stale-exports-comment

Conversation

@cryptodev-2s

@cryptodev-2s cryptodev-2s commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Explanation

The comment above expectCorrectWorkspaceExports says packages set up "ESM- and CommonJS-compatible exports", but the function it introduces asserts the opposite:

expectWorkspaceField(workspace, 'exports["."].require', null);
expectWorkspaceField(workspace, 'exports["."].import', null);
expectWorkspaceField(workspace, 'main', null);

References

Part of WPC-1161.

Checklist

  • I've updated the test suite for new or updated code as appropriate (comment only)
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed (no published package is touched)
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

Low Risk
Documentation-only comment fix in yarn.config.cjs with no behavioural impact.

Overview
Updates the yarn constraints comment above expectCorrectWorkspaceExports so it says non-root packages must configure ESM-only exports, not dual ESM/CommonJS.

The wording previously described removed behaviour and did not match what the constraint actually checks (no separate require/import export conditions, no main). No runtime or constraint logic changes—comment only.

Reviewed by Cursor Bugbot for commit f276d99. Bugbot is set up for automated code reviews on this repo. Configure here.

@cryptodev-2s
cryptodev-2s deployed to default-branch September 15, 2026 13:43 — with GitHub Actions Active
@cryptodev-2s cryptodev-2s self-assigned this Sep 15, 2026
@cryptodev-2s
cryptodev-2s requested a review from a team September 15, 2026 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant