-
-
Notifications
You must be signed in to change notification settings - Fork 308
feat(transaction-pay-controller): atomic quoting for subsidized max Money Account deposits #10224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
OGPoyraz
wants to merge
7
commits into
main
Choose a base branch
from
ogp/CONF-1949
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
103ddbe
feat(transaction-pay-controller): atomic quoting for subsidized max M…
OGPoyraz b5837e3
style(transaction-pay-controller): fix formatting
OGPoyraz 5747aa9
test(transaction-pay-controller): cover atomic promotion guards and s…
OGPoyraz b4296ef
docs(transaction-pay-controller): reference PR in changelog
OGPoyraz e81860e
Fix changelog
OGPoyraz ada5102
feat(transaction-pay-controller): address review feedback on atomic m…
OGPoyraz 6616ef8
Merge remote-tracking branch 'origin/main' into ogp/CONF-1949
OGPoyraz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Order demotion misses nested types
Medium Severity
The demote path skips order flows by comparing
transaction.typetoperpsDepositAndOrderandpredictDepositAndOrder, so nested order transactions still demote. An unsubsidized atomic quote then drops its embedded order calls and submits as a non-atomic vault deposit instead.Reviewed by Cursor Bugbot for commit 6616ef8. Configure here.