Conversation
Avoid writing deep-equal metadata, balances, and prices so Immer does not emit patches that publish identical stateChange events.
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Repeated asset polls often return the same metadata, balances, and prices as objects with new identities.
#updateStateassigned those values unconditionally, so Immer recorded patches even when every field was already in state.BaseController.update()then publishedstateChange, which hosts persist.This skips assignment when the computed next value is deep-equal to the current slice. No-op polls no longer produce patches or
stateChange; a real amount/price/metadata change still publishes once.References
N/A — host-side persistence cost from identical
AssetsControllerupdates.Checklist
Made with Cursor