Skip to content

fix(keyring-controller): fix preview build (unused typecast) #10221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ccharly wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −6
Draft

fix(keyring-controller): fix preview build (unused typecast) #10221

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions packages/keyring-controller/src/KeyringController.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -641,12 +641,8 @@ const hdKeyringV2Builder: KeyringV2Builder = Object.assign(
const simpleKeyringV2Builder: KeyringV2Builder = Object.assign(
(keyring: Keyring): KeyringV2 =>
new SimpleKeyringV2({
// @ts-expect-error TODO: `Keyring` here comes from `@metamask/keyring-utils`,
// which still depends on `@metamask/utils@^11`, while this package now
// depends on the workspace copy at v12. That leaves two distinct identities
// for the same type, so the cast no longer overlaps. Remove this once the
// keyring packages depend on v12.
legacyKeyring: keyring as SimpleKeyring,
// TODO: Remove this cast once `@metamask/utils` is re-aligned on `accounts` repository.
legacyKeyring: keyring as unknown as ConstructorParameters<typeof SimpleKeyringV2>[0]['legacyKeyring'],
}),
{ type: KeyringTypes.simple as string },
);
Expand Down
Loading