Conversation
huggingbot
reviewed
Sep 14, 2026
|
|
||
| After classification, migrate every v1 item to v2. | ||
|
|
||
| ### v2 secret metadata |
Member
There was a problem hiding this comment.
how would we know if a v2 is already checked and fixed? i think we can have a v3 on the migrationVersion after a v2 is checked and fixed. As for v1, after it's been checked and fixed, we can run the migration and it move to v3. Wdyt?
huggingbot
reviewed
Sep 14, 2026
|
|
||
| **Risk:** The repair may run at the wrong point in the unlock or secret-add flow. A normal fetch or migration can fail before the repair gets a chance to inspect the remote secret metadata. | ||
|
|
||
| 1. When exactly should the repair run: during social-login unlock, before adding a new secret, after a known fetch or migration failure, or at another point? |
Member
There was a problem hiding this comment.
if we're already running the check during unlock, do we still need to run it when adding a new key or when changing password? they could serve as a fallback i guess
Member
|
how do we run the fix for users who don't update the app? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
References
Checklist